[SPARK-34028][SQL] Cleanup "unreachable code" compilation warning

[LuciferYang]

What changes were proposed in this pull request?

There is one compilation warning as follow:

[WARNING] [Warn] /spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:1555: [other-match-analysis @ org.apache.spark.sql.catalyst.catalog.SessionCatalog.lookupFunction.catalogFunction] unreachable code

This compilation warning is due to NoSuchPermanentFunctionException is sub-class of AnalysisException and if there is NoSuchPermanentFunctionException be thrown out, it will be catch by case _: AnalysisException => failFunctionLookup(name), so case _: NoSuchPermanentFunctionException => failFunctionLookup(name) is unreachable code.

This pr remove case _: NoSuchPermanentFunctionException => failFunctionLookup(name) directly because both these 2 branches handle exceptions in the same way: failFunctionLookup(name)

Why are the changes needed?

Cleanup "unreachable code" compilation warnings.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass the Jenkins or GitHub Action

[SparkQA]

Test build #133737 has finished for PR 31064 at commit 8942881.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38325/

[SparkQA]

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38325/

[HyukjinKwon]

LGTM. It's a strictly a followup of Okay, it's from 5c8fad7.

[HyukjinKwon]

Merged to master.

[LuciferYang]

thx ~ @HyukjinKwon