Skip to content

Conversation

@beliefer
Copy link
Contributor

@beliefer beliefer commented Jan 5, 2021

What changes were proposed in this pull request?

Change FrameLessOffsetWindowFunction as sealed abstract class so that simplify pattern match.

Why are the changes needed?

Simplify pattern match

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

Jenkins test

beliefer and others added 30 commits June 19, 2020 10:36
@github-actions github-actions bot added the SQL label Jan 5, 2021
@HyukjinKwon
Copy link
Member

@beliefer just out of curiosity, I think your master branch in your fork is not synced properly for whatever reason. When you sync your master branch, you should rebase instead of merge. Otherwise, the merge commits show as shown in this PR above. I think you will have to git rebase --force for your master branch to get rid of the merge commits above.

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38248/

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38248/

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Test build #133660 has finished for PR 31026 at commit bebe4c2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented Jan 5, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Test build #133686 has finished for PR 31026 at commit bebe4c2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented Jan 6, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Jan 6, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38291/

@SparkQA
Copy link

SparkQA commented Jan 6, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38291/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @beliefer and @HyukjinKwon .
Merged to master for Apache Spark 3.2.0.

@beliefer
Copy link
Contributor Author

beliefer commented Jan 6, 2021

@dongjoon-hyun Thanks for your help! @HyukjinKwon Thanks for your sincerely suggestion, I will learn and try it.

@HyukjinKwon
Copy link
Member

LGTM too

@SparkQA
Copy link

SparkQA commented Jan 6, 2021

Test build #133703 has finished for PR 31026 at commit bebe4c2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants