-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-34004][SQL] Change FrameLessOffsetWindowFunction as sealed abstract class #31026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Show resolved
Hide resolved
|
@beliefer just out of curiosity, I think your |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #133660 has finished for PR 31026 at commit
|
|
retest this please |
|
Test build #133686 has finished for PR 31026 at commit
|
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @beliefer and @HyukjinKwon .
Merged to master for Apache Spark 3.2.0.
|
@dongjoon-hyun Thanks for your help! @HyukjinKwon Thanks for your sincerely suggestion, I will learn and try it. |
|
LGTM too |
|
Test build #133703 has finished for PR 31026 at commit
|
What changes were proposed in this pull request?
Change
FrameLessOffsetWindowFunctionas sealed abstract class so that simplify pattern match.Why are the changes needed?
Simplify pattern match
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Jenkins test