[SPARK-33977][SQL][DOCS] Add doc for "'like any' and 'like all' operators" #31008

beliefer · 2021-01-04T10:19:58Z

What changes were proposed in this pull request?

Add doc for 'like any' and 'like all' operators in sql-ref-syntx-qry-select-like.cmd

Why are the changes needed?

make the usage of 'like any' and 'like all' known to more users

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

No tests

beliefer · 2021-01-04T10:29:01Z

cc @wangyum

wangyum · 2021-01-04T11:58:54Z

docs/sql-ref-syntax-qry-select-like.md

 ```sql
 [ NOT ] { LIKE search_pattern [ ESCAPE esc_char ] | [ RLIKE | REGEXP ] regex_pattern }
+
+[ NOT ] { LIKE predicate_quantifiers ( search_pattern [ , ... ]) }


LIKE predicate_quantifiers ( search_pattern [ , ... ]) -> LIKE quantifier ( search_pattern [ , ...])?

wangyum · 2021-01-04T12:01:22Z

docs/sql-ref-syntax-qry-select-like.md

 ### Description

-A LIKE predicate is used to search for a specific pattern.
+A LIKE predicate is used to search for a specific pattern. LIKE predicate also supports multiple patterns with predicate quantifiers include `SOME`, `ANY`, `ALL`.


`SOME`, `ANY`, `ALL`. -> `ANY`, `SOME` and `ALL`.?

SparkQA · 2021-01-05T01:23:53Z

Test build #133612 has finished for PR 31008 at commit 3d0826e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2021-01-05T02:23:09Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38201/

SparkQA · 2021-01-05T02:58:11Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38201/

SparkQA · 2021-01-05T03:27:17Z

Test build #133640 has finished for PR 31008 at commit d5b0e48.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

maropu · 2021-01-05T07:21:47Z

docs/sql-ref-syntax-qry-select-like.md

 ```sql
 [ NOT ] { LIKE search_pattern [ ESCAPE esc_char ] | [ RLIKE | REGEXP ] regex_pattern }
+
+[ NOT ] { LIKE quantifiers ( search_pattern [ , ... ]) }


quantifiers -> [ ANY | SOME | ALL ]?

We need to describle quantifiers in detail. So I think quantifiers is better.

docs/sql-ref-syntax-qry-select-like.md

maropu · 2021-01-05T07:25:38Z

For reviews, could you put the screenshot of this doc update in Does this PR introduce any user-facing change??

maropu · 2021-01-05T14:00:09Z

docs/sql-ref-syntax-qry-select-like.md

 ### Description

-A LIKE predicate is used to search for a specific pattern.
+A LIKE predicate is used to search for a specific pattern. LIKE predicate also supports multiple patterns with quantifiers include `ANY`, `SOME` and `ALL`.


nit: LIKE predicate -> This clause

How about This predicate?

SparkQA · 2021-01-06T03:21:10Z

Test build #133704 has finished for PR 31008 at commit 524759a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2021-01-06T04:00:51Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38292/

SparkQA · 2021-01-06T04:42:12Z

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38292/

maropu · 2021-01-06T12:15:11Z

Thanks! Merged to master/branch-3.1.

…tors" ### What changes were proposed in this pull request? Add doc for 'like any' and 'like all' operators in sql-ref-syntx-qry-select-like.cmd ### Why are the changes needed? make the usage of 'like any' and 'like all' known to more users ### Does this PR introduce _any_ user-facing change? Yes. <img width="687" alt="Screen Shot 2021-01-06 at 21 10 38" src="https://user-images.githubusercontent.com/692303/103767385-dc1ffb80-5063-11eb-9529-89479531425f.png"> <img width="495" alt="Screen Shot 2021-01-06 at 21 11 06" src="https://user-images.githubusercontent.com/692303/103767391-dde9bf00-5063-11eb-82ce-63bdd11593a1.png"> <img width="406" alt="Screen Shot 2021-01-06 at 21 11 20" src="https://user-images.githubusercontent.com/692303/103767396-df1aec00-5063-11eb-8e81-a192e6c72431.png"> ### How was this patch tested? No tests Closes #31008 from beliefer/SPARK-33977. Lead-authored-by: gengjiaan <[email protected]> Co-authored-by: beliefer <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>

beliefer · 2021-01-06T15:18:49Z

@maropu Thanks for your work! @wangyum @srowen Thanks for your review.
Specially, Thanks for your screen shot @maropu

…tors" Add doc for 'like any' and 'like all' operators in sql-ref-syntx-qry-select-like.cmd make the usage of 'like any' and 'like all' known to more users Yes. <img width="687" alt="Screen Shot 2021-01-06 at 21 10 38" src="https://user-images.githubusercontent.com/692303/103767385-dc1ffb80-5063-11eb-9529-89479531425f.png"> <img width="495" alt="Screen Shot 2021-01-06 at 21 11 06" src="https://user-images.githubusercontent.com/692303/103767391-dde9bf00-5063-11eb-82ce-63bdd11593a1.png"> <img width="406" alt="Screen Shot 2021-01-06 at 21 11 20" src="https://user-images.githubusercontent.com/692303/103767396-df1aec00-5063-11eb-8e81-a192e6c72431.png"> No tests Closes apache#31008 from beliefer/SPARK-33977. Lead-authored-by: gengjiaan <[email protected]> Co-authored-by: beliefer <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>

beliefer and others added 30 commits June 19, 2020 10:36

Reuse completeNextStageWithFetchFailure

4a6f903

Merge remote-tracking branch 'upstream/master'

96456e2

Merge remote-tracking branch 'upstream/master'

4314005

Merge remote-tracking branch 'upstream/master'

d6af4a7

Merge remote-tracking branch 'upstream/master'

f69094f

Merge remote-tracking branch 'upstream/master'

b86a42d

Merge branch 'master' of github.com:beliefer/spark

2ac5159

Merge remote-tracking branch 'upstream/master'

9021d6c

Merge branch 'master' of github.com:beliefer/spark

74a2ef4

Merge remote-tracking branch 'upstream/master'

9828158

Merge remote-tracking branch 'upstream/master'

9cd1aaf

Merge remote-tracking branch 'upstream/master'

abfcbb9

Merge remote-tracking branch 'upstream/master'

07c6c81

Merge remote-tracking branch 'upstream/master'

580130b

Merge branch 'master' of github.com:beliefer/spark

3712808

Merge remote-tracking branch 'upstream/master'

6107413

Merge remote-tracking branch 'upstream/master'

4b799b4

Merge remote-tracking branch 'upstream/master'

ee0ecbf

Merge remote-tracking branch 'upstream/master'

596bc61

Merge remote-tracking branch 'upstream/master'

0164e2f

Merge remote-tracking branch 'upstream/master'

90b79fc

Merge remote-tracking branch 'upstream/master'

2cef3a9

Merge remote-tracking branch 'upstream/master'

c26b64f

Merge remote-tracking branch 'upstream/master'

2e02cd2

Merge remote-tracking branch 'upstream/master'

a6d0741

Merge remote-tracking branch 'upstream/master'

82e5b2c

Merge remote-tracking branch 'upstream/master'

70bbf5d

Merge remote-tracking branch 'upstream/master'

126a51e

Merge remote-tracking branch 'upstream/master'

f2ceacd

Merge remote-tracking branch 'upstream/master'

5ad208f

beliefer added 2 commits January 4, 2021 18:21

Add doc for like any|all operators

e159efc

Add doc for like any|all operators

3d0826e

wangyum reviewed Jan 4, 2021

View reviewed changes

github-actions bot added the DOCS label Jan 4, 2021

beliefer added 3 commits January 5, 2021 10:18

Update doc

348c564

Update doc

a52e46f

Update doc

d5b0e48

maropu reviewed Jan 5, 2021

View reviewed changes

docs/sql-ref-syntax-qry-select-like.md Outdated Show resolved Hide resolved

maropu changed the title ~~[SPARK-33977][SQL] Add doc for "'like any' and 'like all' operators"~~ [SPARK-33977][SQL][DOCS] Add doc for "'like any' and 'like all' operators" Jan 5, 2021

maropu reviewed Jan 5, 2021

View reviewed changes

srowen approved these changes Jan 5, 2021

View reviewed changes

Update doc

524759a

maropu approved these changes Jan 6, 2021

View reviewed changes

maropu closed this Jan 6, 2021

[SPARK-33977][SQL][DOCS] Add doc for "'like any' and 'like all' operators" #31008

[SPARK-33977][SQL][DOCS] Add doc for "'like any' and 'like all' operators" #31008

Uh oh!

Conversation

beliefer commented Jan 4, 2021 • edited by maropu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

beliefer commented Jan 4, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Jan 5, 2021

Uh oh!

SparkQA commented Jan 5, 2021

Uh oh!

SparkQA commented Jan 5, 2021

Uh oh!

SparkQA commented Jan 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beliefer Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maropu commented Jan 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Jan 6, 2021

Uh oh!

SparkQA commented Jan 6, 2021

Uh oh!

SparkQA commented Jan 6, 2021

Uh oh!

maropu commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

beliefer commented Jan 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

beliefer commented Jan 4, 2021 •

edited by maropu

Loading

beliefer Jan 5, 2021 •

edited

Loading

maropu commented Jan 6, 2021 •

edited

Loading