[SPARK-26341][WEBUI][FOLLOWUP] Update stage memory metrics on stage end. #30858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #133083 has finished for PR 30858 at commit
|
dongjoon-hyun
approved these changes
Dec 21, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @sarutak . Merged to master/3.1.
cc @AngersZhuuuu since he is the original author.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 21, 2020
### What changes were proposed in this pull request? This is a followup PR for #30573 . After this change applied, stage memory metrics will be updated on stage end. ### Why are the changes needed? After #30573, executor memory metrics is updated on stage end but stage memory metrics is not updated. It's better to update both metrics like `updateStageLevelPeakExecutorMetrics` does. ### Does this PR introduce _any_ user-facing change? Yes. stage memory metrics is updated more accurately. ### How was this patch tested? After I run a job and visited `/api/v1/<appid>/stages`, I confirmed `peakExecutorMemory` metrics is shown even though the life time of each stage is very short . I also modify the json files for `HistoryServerSuite`. Closes #30858 from sarutak/followup-SPARK-26341. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 8e26339) Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
|
Sorry for late reply, it's a good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup PR for #30573 .
After this change applied, stage memory metrics will be updated on stage end.
Why are the changes needed?
After #30573, executor memory metrics is updated on stage end but stage memory metrics is not updated.
It's better to update both metrics like
updateStageLevelPeakExecutorMetricsdoes.Does this PR introduce any user-facing change?
Yes. stage memory metrics is updated more accurately.
How was this patch tested?
After I run a job and visited
/api/v1/<appid>/stages, I confirmedpeakExecutorMemorymetrics is shown even though the life time of each stage is very short .I also modify the json files for
HistoryServerSuite.