[SPARK-33735][SQL] Handle UPDATE in ReplaceNullWithFalseInPredicate #30787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
cc @rdblue |
Member
|
LGTM. Pending tests. |
viirya
approved these changes
Dec 15, 2020
|
Kubernetes integration test starting |
rdblue
approved these changes
Dec 15, 2020
|
Kubernetes integration test status failure |
dongjoon-hyun
approved these changes
Dec 15, 2020
Member
|
Merged to master for Apache Spark 3.2.0. Thanks, @aokolnychyi , @dbtsai , @viirya , @rdblue . |
|
Test build #132842 has finished for PR 30787 at commit
|
Member
|
LGTM, thanks @aokolnychyi. |
Contributor
Author
|
Thanks, everyone! |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
### What changes were proposed in this pull request? This PR adds `UpdateTable` to supported plans in `ReplaceNullWithFalseInPredicate`. ### Why are the changes needed? This change allows Spark to optimize update conditions like we optimize filters. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? This PR extends the existing test cases to also cover `UpdateTable`. Closes apache#30787 from aokolnychyi/spark-33735. Authored-by: Anton Okolnychyi <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4d56d43) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds
UpdateTableto supported plans inReplaceNullWithFalseInPredicate.Why are the changes needed?
This change allows Spark to optimize update conditions like we optimize filters.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This PR extends the existing test cases to also cover
UpdateTable.