[SPARK-33796][DOCS] Show hidden text from the left menu of Spark Doc #30786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
changed the title
gengliangwang
changed the title
gengliangwang
commented
Dec 15, 2020
| } | ||
|
|
||
| .left-menu { | ||
| width: 399px; |
Member
Author
There was a problem hiding this comment.
The width is specified as 210px in its parent .left-menu-wrapper
|
Test build #132838 has finished for PR 30786 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
HyukjinKwon
approved these changes
Dec 16, 2020
Member
|
Thanks @gengliangwang for fixing this! |
Member
|
Merged to master and branch-3.1. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Dec 16, 2020
### What changes were proposed in this pull request? If the text in the left menu of Spark is too long, it will be hidden.  This PR is to fix the style issue. ### Why are the changes needed? Improve the UI of Spark documentation. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual test After changes:  Closes #30786 from gengliangwang/fixDocStyle. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit dd042f5) Signed-off-by: HyukjinKwon <[email protected]>
Member
|
@gengliangwang, should we fix it in branch-3.0 too? it has a conflict. |
Member
Author
|
@HyukjinKwon sure, I will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If the text in the left menu of Spark is too long, it will be hidden.
This PR is to fix the style issue.
Why are the changes needed?
Improve the UI of Spark documentation.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test
After changes: