[SPARK-33732][K8S][TESTS] Kubernetes integration tests doesn't work with Minikube 1.9+ #30700

sarutak · 2020-12-10T04:31:43Z

What changes were proposed in this pull request?

This PR changes Minikube.scala for Kubernetes integration tests to work with Minikube 1.9+.
Minikube.scala assumes that apiserver.key and apiserver.crt are in ~/.minikube/.
But as of Minikube 1.9, they are in ~/.minikube/profiles/<profile>.

Why are the changes needed?

Currently, Kubernetes integration tests doesn't work with Minikube 1.9+.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I confirmed the following test passes.

$ build/sbt -Pkubernetes -Pkubernetes-integration-tests package 'kubernetes-integration-tests/testOnly -- -z "SparkPi with no"'

sarutak · 2020-12-10T04:36:24Z

...s/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala

  def executeMinikube(action: String, args: String*): Seq[String] = {
    ProcessUtils.executeProcess(
-      Array("bash", "-c", s"minikube $action ${args.mkString(" ")}"),
+      Array("bash", "-c", s"MINIKUBE_IN_STYLE=true minikube $action ${args.mkString(" ")}"),


For reviewers: Without this change, the output of minikube profile is with the prefix * .
(e.g. * minikube rather than minikube) in case stderr is not tty.

dongjoon-hyun

Thank you so much, @sarutak . I copied the cert files manually so far. This is very helpful.

...s/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala

SparkQA · 2020-12-10T05:03:57Z

Test build #132539 has finished for PR 30700 at commit f73b93f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-12-10T05:13:19Z

Test build #132541 has finished for PR 30700 at commit 4730d90.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2020-12-10T05:36:40Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37143/

SparkQA · 2020-12-10T05:42:46Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37145/

SparkQA · 2020-12-10T05:42:47Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37145/

SparkQA · 2020-12-10T05:59:42Z

Test build #132543 has finished for PR 30700 at commit 7231cbf.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

dongjoon-hyun

+1, LGTM.
Merged to master/3.1.

…ith Minikube 1.9+ ### What changes were proposed in this pull request? This PR changes `Minikube.scala` for Kubernetes integration tests to work with Minikube 1.9+. `Minikube.scala` assumes that `apiserver.key` and `apiserver.crt` are in `~/.minikube/`. But as of Minikube 1.9, they are in `~/.minikube/profiles/<profile>`. ### Why are the changes needed? Currently, Kubernetes integration tests doesn't work with Minikube 1.9+. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I confirmed the following test passes. ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests package 'kubernetes-integration-tests/testOnly -- -z "SparkPi with no"' ``` Closes #30700 from sarutak/minikube-1.9. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 795db05) Signed-off-by: Dongjoon Hyun <[email protected]>

SparkQA · 2020-12-10T06:06:29Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37143/

dongjoon-hyun · 2020-12-10T06:17:20Z

BTW, could you make a backport to branch-3.0/branch-2.4?

sarutak · 2020-12-10T06:24:10Z

O.K, I'll open PRs for them.

dongjoon-hyun · 2020-12-10T06:28:48Z

Thank you so much!

SparkQA · 2020-12-10T06:29:06Z

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37147/

SparkQA · 2020-12-10T06:29:07Z

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37147/

…ork with Minikube 1.9+ ### What changes were proposed in this pull request? This is a backport of #30700 . This PR changes `Minikube.scala` for Kubernetes integration tests to work with Minikube 1.9+. `Minikube.scala` assumes that `apiserver.key` and `apiserver.crt` are in `~/.minikube/`. But as of Minikube 1.9, they are in `~/.minikube/profiles/<profile>`. ### Why are the changes needed? Currently, Kubernetes integration tests doesn't work with Minikube 1.9+. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I confirmed the following test passes. ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests package 'kubernetes-integration-tests/testOnly -- -z "SparkPi with no"' ``` Closes #30702 from sarutak/minikube-1.9-branch-3.0. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

…ork with Minikube 1.9+ #30702 ### What changes were proposed in this pull request? This is a backport of #30700 . This PR changes `Minikube.scala` for Kubernetes integration tests to work with Minikube 1.9+. `Minikube.scala` assumes that `apiserver.key` and `apiserver.crt` are in `~/.minikube/`. But as of Minikube 1.9, they are in `~/.minikube/profiles/<profile>`. ### Why are the changes needed? Currently, Kubernetes integration tests doesn't work with Minikube 1.9+. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? I confirmed the following test passes. ``` $ build/sbt -Pkubernetes -Pkubernetes-integration-tests package 'kubernetes-integration-tests/testOnly -- -z "SparkPi with no"' ``` Closes #30704 from sarutak/minikube-1.9-branch-2.4. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>

sarutak added 3 commits December 8, 2020 16:59

Change Minikube.scala for Minikube 1.9.0+

6611524

Suppress the decoration for the output of minikube profile.

01996a2

Refactoring

f73b93f

github-actions bot added the KUBERNETES label Dec 10, 2020

sarutak commented Dec 10, 2020

View reviewed changes

dongjoon-hyun reviewed Dec 10, 2020

View reviewed changes

...s/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala Outdated Show resolved Hide resolved

Removed unused variable MINIKUBE_APISERVER_CERT_PATH

4730d90

dongjoon-hyun reviewed Dec 10, 2020

View reviewed changes

...s/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala Outdated Show resolved Hide resolved

Simplify the logic.

7231cbf

dongjoon-hyun approved these changes Dec 10, 2020

View reviewed changes

dongjoon-hyun closed this in 795db05 Dec 10, 2020

sarutak mentioned this pull request Dec 10, 2020

[SPARK-33732][K8S][TESTS][3.0] Kubernetes integration tests doesn't work with Minikube 1.9+ #30702

Closed

sarutak mentioned this pull request Dec 10, 2020

[SPARK-33732][K8S][TESTS][2.4] Kubernetes integration tests doesn't work with Minikube 1.9+ #30702 #30704

Closed

[SPARK-33732][K8S][TESTS] Kubernetes integration tests doesn't work with Minikube 1.9+ #30700

[SPARK-33732][K8S][TESTS] Kubernetes integration tests doesn't work with Minikube 1.9+ #30700

Uh oh!

Conversation

sarutak commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

sarutak Dec 10, 2020

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

dongjoon-hyun commented Dec 10, 2020

Uh oh!

sarutak commented Dec 10, 2020

Uh oh!

dongjoon-hyun commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

SparkQA commented Dec 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sarutak commented Dec 10, 2020 •

edited

Loading

dongjoon-hyun left a comment •

edited

Loading