[MINOR][SQL] Spelling: binaries - readBinarys #30680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
HyukjinKwon
changed the title
|
Can one of the admins verify this patch? |
Member
|
Tough call - probably safe but not sure it's worth it. It may be a bit on purpose, as in readIntegers and readBinarys even if obviously that's not the plural of binary. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replacing
readBinaryswithreadBinariesWhy are the changes needed?
per @srowen #30323 (comment)
Does this PR introduce any user-facing change?
I suspect this is technically a public API. GitHub doesn't appear to show any instances beyond copies of the source code.
How was this patch tested?
This was covered by CI at one point.