-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][SQL] Spelling: filters - PushedFilers #30678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
Thanks bot |
Signed-off-by: Josh Soref <[email protected]>
903d13e to
3137298
Compare
|
@srowen / @bersprockets: anything I need to do to push this along? |
|
Jenkins test this please |
|
Test build #136265 has started for PR 30678 at commit |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #136277 has finished for PR 30678 at commit
|
|
Sorry I'm getting to this late - and this is probably an ignorant question, but would this cause any user code to break? like would existing code be setting this under the wrongly-named key at the moment? Just want to make sure we don't break things. |
|
@srowen: I don't know - nor am I particularly certain about how to check, but apparently the bot is very strongly opinionated. |
|
Ignore the bot, it's just doing housekeeping. That's my only concern - would this break any user code? is this property even observable or settable by users? |
|
I can't speak definitively, but the most prominent hits are this PR itself or other references to apache/spark internals. @MaxGekk added this in #29145 in July of 2020, @gengliangwang, @HeartSaVioR, @bersprockets, and @HyukjinKwon seem to be the people most likely to be able to give an educated opinion (and notably, @bersprockets is the one who suggested doing this). |
|
The method |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #136304 has finished for PR 30678 at commit
|
|
@jsoref Could you update PR's description, for instance fill in |
|
@MaxGekk: Done (and the bot seems to hate me) |
|
(Note to committers; when reopening, please remove Stale tag as well, which is a marker Github Bot leverages to check and close the PR.) |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
gengliangwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
+1, LGTM, I am merging this to master. |
|
Test build #136318 has finished for PR 30678 at commit
|
What changes were proposed in this pull request?
Consistently correct the spelling of
PushedFiltersWhy are the changes needed?
@bersprockets noted that it's wrong
Does this PR introduce any user-facing change?
Technically, I think it does. Practically, neither Google nor GitHub show anyone using
pushedFilersoutside of forks (or the discussion about fixing it started at #30323 (comment))How was this patch tested?
None beyond CI in the previous PR