Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
d9f6788
[WIP] FIX HiveThriftHttpServerSuite flakiness
yaooqinn Dec 7, 2020
13b2b8f
sep toTStatus
yaooqinn Dec 7, 2020
772e544
simplify libthrift dep
yaooqinn Dec 7, 2020
053b452
fix build
yaooqinn Dec 7, 2020
f889060
random port
yaooqinn Dec 7, 2020
869d24b
dumplogs
yaooqinn Dec 7, 2020
7be1980
dumplogs after
yaooqinn Dec 7, 2020
b73943c
exclude jsr311 from sbt build
yaooqinn Dec 8, 2020
09811e1
revert and trigger
yaooqinn Dec 8, 2020
34944a0
restore thrift version
yaooqinn Dec 8, 2020
7fe3c7b
restore thrift version
yaooqinn Dec 8, 2020
5c65a55
fix
yaooqinn Dec 8, 2020
7a33e56
refine
yaooqinn Dec 8, 2020
47dca28
deps regen
yaooqinn Dec 8, 2020
2f89a68
info
yaooqinn Dec 9, 2020
614e650
add exclusion
yaooqinn Dec 9, 2020
0447184
eclude jetty-web app
yaooqinn Dec 9, 2020
abebd30
log protential jar conflicts
yaooqinn Dec 9, 2020
927ff86
improve log
yaooqinn Dec 9, 2020
893d8ed
eclude for assembly
yaooqinn Dec 9, 2020
b6ebd4c
only yarn
yaooqinn Dec 10, 2020
2a45b03
fix yarn
yaooqinn Dec 10, 2020
436d3fb
refine
yaooqinn Dec 10, 2020
c893d56
add one missing test
yaooqinn Dec 11, 2020
e4b5264
add one missing test 2
yaooqinn Dec 11, 2020
ea16b7a
fix tests
yaooqinn Dec 11, 2020
c227bc8
debug hadoop 27
yaooqinn Dec 12, 2020
a756cfb
Revert "debug hadoop 27"
yaooqinn Dec 12, 2020
c64c94e
Revert "Revert "debug hadoop 27""
yaooqinn Dec 12, 2020
0ad4e9d
Revert "Revert "Revert "debug hadoop 27"""
yaooqinn Dec 12, 2020
4efd4b8
exclude jersey core
yaooqinn Dec 12, 2020
c63acff
exclude jersey core
yaooqinn Dec 12, 2020
fee0e31
servlet-api
yaooqinn Dec 12, 2020
47791c9
deps regen
yaooqinn Dec 12, 2020
afbfdba
trigger ga
yaooqinn Dec 13, 2020
986686d
license
yaooqinn Dec 14, 2020
f0ac817
comments
yaooqinn Dec 14, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE-binary
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,6 @@ Common Development and Distribution License (CDDL) 1.1
------------------------------------------------------

javax.el:javax.el-api https://javaee.github.io/uel-ri/
javax.servlet:javax.servlet-api https://javaee.github.io/servlet-spec/
javax.servlet.jsp:jsp-api
javax.transaction:jta http://www.oracle.com/technetwork/java/index.html
javax.xml.bind:jaxb-api https://github.com/javaee/jaxb-v2
Expand Down Expand Up @@ -553,6 +552,7 @@ Eclipse Public License (EPL) 2.0
--------------------------------

jakarta.annotation:jakarta-annotation-api https://projects.eclipse.org/projects/ee4j.ca
jakarta.servlet:jakarta.servlet-api https://projects.eclipse.org/projects/ee4j.servlet
jakarta.ws.rs:jakarta.ws.rs-api https://github.com/eclipse-ee4j/jaxrs-api
org.glassfish.hk2.external:jakarta.inject

Expand Down
6 changes: 3 additions & 3 deletions core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,9 @@
<scope>compile</scope>
</dependency>
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<version>${javaxservlet.version}</version>
<groupId>jakarta.servlet</groupId>
<artifactId>jakarta.servlet-api</artifactId>
<version>${jakartaservlet.version}</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down
2 changes: 1 addition & 1 deletion dev/deps/spark-deps-hadoop-2.7-hive-2.3
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,14 @@ jackson-xc/1.9.13//jackson-xc-1.9.13.jar
jakarta.activation-api/1.2.1//jakarta.activation-api-1.2.1.jar
jakarta.annotation-api/1.3.5//jakarta.annotation-api-1.3.5.jar
jakarta.inject/2.6.1//jakarta.inject-2.6.1.jar
jakarta.servlet-api/4.0.3//jakarta.servlet-api-4.0.3.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this library to LICENSE-binary. (cc @srowen )

jakarta.validation-api/2.0.2//jakarta.validation-api-2.0.2.jar
jakarta.ws.rs-api/2.1.6//jakarta.ws.rs-api-2.1.6.jar
jakarta.xml.bind-api/2.3.2//jakarta.xml.bind-api-2.3.2.jar
janino/3.0.16//janino-3.0.16.jar
javassist/3.25.0-GA//javassist-3.25.0-GA.jar
javax.inject/1//javax.inject-1.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javax.servlet-api/3.1.0//javax.servlet-api-3.1.0.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no reference, we can remove this from LICENSE-binary.

javolution/5.5.1//javolution-5.5.1.jar
jaxb-api/2.2.2//jaxb-api-2.2.2.jar
jaxb-runtime/2.3.2//jaxb-runtime-2.3.2.jar
Expand Down
1 change: 1 addition & 0 deletions dev/deps/spark-deps-hadoop-3.2-hive-2.3
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ jackson-module-scala_2.12/2.10.5//jackson-module-scala_2.12-2.10.5.jar
jakarta.activation-api/1.2.1//jakarta.activation-api-1.2.1.jar
jakarta.annotation-api/1.3.5//jakarta.annotation-api-1.3.5.jar
jakarta.inject/2.6.1//jakarta.inject-2.6.1.jar
jakarta.servlet-api/4.0.3//jakarta.servlet-api-4.0.3.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realised that we still add javax.servlet-api/3.1.0//javax.servlet-api-3.1.0.jar below in Hadoop 3. Do you know why this is not excluded? Looks like it can conflict.

jakarta.validation-api/2.0.2//jakarta.validation-api-2.0.2.jar
jakarta.ws.rs-api/2.1.6//jakarta.ws.rs-api-2.1.6.jar
jakarta.xml.bind-api/2.3.2//jakarta.xml.bind-api-2.3.2.jar
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
<parquet.version>1.10.1</parquet.version>
<orc.version>1.6.6</orc.version>
<jetty.version>9.4.28.v20200408</jetty.version>
<javaxservlet.version>3.1.0</javaxservlet.version>
<jakartaservlet.version>4.0.3</jakartaservlet.version>
<chill.version>0.9.5</chill.version>
<ivy.version>2.4.0</ivy.version>
<oro.version>2.0.8</oro.version>
Expand Down
27 changes: 26 additions & 1 deletion project/SparkBuild.scala
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,8 @@ object SparkBuild extends PomBuild {

enable(KubernetesIntegrationTests.settings)(kubernetesIntegrationTests)

enable(YARN.settings)(yarn)

/**
* Adds the ability to run the spark shell directly from SBT without building an assembly
* jar.
Expand Down Expand Up @@ -654,7 +656,21 @@ object DependencyOverrides {
*/
object ExcludedDependencies {
lazy val settings = Seq(
libraryDependencies ~= { libs => libs.filterNot(_.name == "groovy-all") }
libraryDependencies ~= { libs => libs.filterNot(_.name == "groovy-all") },
// SPARK-33705: Due to sbt compiler issues, it brings exclusions defined in maven pom back to
// the classpath directly and assemble test scope artifacts to assembly/target/scala-xx/jars,
// which is also will be added to the classpath of some unit tests that will build a subprocess
// to run `spark-submit`, e.g. HiveThriftServer2Test.
//
// These artifacts are for the jersey-1 API but Spark use jersey-2 ones, so it cause test
// flakiness w/ jar conflicts issues.
//
// Also jersey-1 is only used by yarn module(see resource-managers/yarn/pom.xml) for testing
// purpose only. Here we exclude them from the whole project scope and add them w/ yarn only.
excludeDependencies ++= Seq(
ExclusionRule(organization = "com.sun.jersey"),
ExclusionRule("javax.servlet", "javax.servlet-api"),
ExclusionRule("javax.ws.rs", "jsr311-api"))
)
}

Expand Down Expand Up @@ -758,6 +774,15 @@ object Hive {
)
}

object YARN {
lazy val settings = Seq(
excludeDependencies --= Seq(
ExclusionRule(organization = "com.sun.jersey"),
ExclusionRule("javax.servlet", "javax.servlet-api"),
ExclusionRule("javax.ws.rs", "jsr311-api"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, so in Yarn are we adding javax.servlet-api back with jakarta.servlet-api?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THE YARN TESTS relies on this, so I
added it back here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed only for tests? or during actual runtime with the regular release?

Copy link
Member Author

@yaooqinn yaooqinn Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for test only.

FYI,

<!--
Jersey 1 dependencies only required for YARN integration testing. Creating a YARN cluster
in the JVM requires starting a Jersey 1-based web application.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for test-only, let's include this only for the test scope. It's going to introduce another problem with conflicting jars. Can we try to exclude and include this with test-only scope? If that doesn't work with SBT, that might be fine since we don't use SBT for official release process. We can add documentation for clarification.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarification, we're all fine as long as ...:

  • dev/deps/spark-deps-hadoop-3.2-hive-2.3 does not have the duplicated jars. This file contains the list of jars for the release.
  • The tests pass

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yaooqinn.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my pleasure:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed a JIRA for you: SPARK-34111 :-).

)
}

object Assembly {
import sbtassembly.AssemblyUtils._
import sbtassembly.AssemblyPlugin.autoImport._
Expand Down
7 changes: 0 additions & 7 deletions resource-managers/yarn/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,6 @@
<artifactId>hadoop-client</artifactId>
</dependency>

<dependency>
<groupId>jakarta.servlet</groupId>
<artifactId>jakarta.servlet-api</artifactId>
<version>4.0.3</version>
<scope>test</scope>
</dependency>

<!-- Explicit listing of transitive deps that are shaded. Otherwise, odd compiler crashes. -->
<dependency>
<groupId>com.google.guava</groupId>
Expand Down
Loading