-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-33705][SQL][TEST] Fix HiveThriftHttpServerSuite flakiness #30643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d9f6788
13b2b8f
772e544
053b452
f889060
869d24b
7be1980
b73943c
09811e1
34944a0
7fe3c7b
5c65a55
7a33e56
47dca28
2f89a68
614e650
0447184
abebd30
927ff86
893d8ed
b6ebd4c
2a45b03
436d3fb
c893d56
e4b5264
ea16b7a
c227bc8
a756cfb
c64c94e
0ad4e9d
4efd4b8
c63acff
fee0e31
47791c9
afbfdba
986686d
f0ac817
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,14 +119,14 @@ jackson-xc/1.9.13//jackson-xc-1.9.13.jar | |
| jakarta.activation-api/1.2.1//jakarta.activation-api-1.2.1.jar | ||
| jakarta.annotation-api/1.3.5//jakarta.annotation-api-1.3.5.jar | ||
| jakarta.inject/2.6.1//jakarta.inject-2.6.1.jar | ||
| jakarta.servlet-api/4.0.3//jakarta.servlet-api-4.0.3.jar | ||
| jakarta.validation-api/2.0.2//jakarta.validation-api-2.0.2.jar | ||
| jakarta.ws.rs-api/2.1.6//jakarta.ws.rs-api-2.1.6.jar | ||
| jakarta.xml.bind-api/2.3.2//jakarta.xml.bind-api-2.3.2.jar | ||
| janino/3.0.16//janino-3.0.16.jar | ||
| javassist/3.25.0-GA//javassist-3.25.0-GA.jar | ||
| javax.inject/1//javax.inject-1.jar | ||
| javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar | ||
| javax.servlet-api/3.1.0//javax.servlet-api-3.1.0.jar | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If there is no reference, we can remove this from |
||
| javolution/5.5.1//javolution-5.5.1.jar | ||
| jaxb-api/2.2.2//jaxb-api-2.2.2.jar | ||
| jaxb-runtime/2.3.2//jaxb-runtime-2.3.2.jar | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,6 +118,7 @@ jackson-module-scala_2.12/2.10.5//jackson-module-scala_2.12-2.10.5.jar | |
| jakarta.activation-api/1.2.1//jakarta.activation-api-1.2.1.jar | ||
| jakarta.annotation-api/1.3.5//jakarta.annotation-api-1.3.5.jar | ||
| jakarta.inject/2.6.1//jakarta.inject-2.6.1.jar | ||
| jakarta.servlet-api/4.0.3//jakarta.servlet-api-4.0.3.jar | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realised that we still add |
||
| jakarta.validation-api/2.0.2//jakarta.validation-api-2.0.2.jar | ||
| jakarta.ws.rs-api/2.1.6//jakarta.ws.rs-api-2.1.6.jar | ||
| jakarta.xml.bind-api/2.3.2//jakarta.xml.bind-api-2.3.2.jar | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -395,6 +395,8 @@ object SparkBuild extends PomBuild { | |||||||
|
|
||||||||
| enable(KubernetesIntegrationTests.settings)(kubernetesIntegrationTests) | ||||||||
|
|
||||||||
| enable(YARN.settings)(yarn) | ||||||||
|
|
||||||||
| /** | ||||||||
| * Adds the ability to run the spark shell directly from SBT without building an assembly | ||||||||
| * jar. | ||||||||
|
|
@@ -654,7 +656,21 @@ object DependencyOverrides { | |||||||
| */ | ||||||||
| object ExcludedDependencies { | ||||||||
| lazy val settings = Seq( | ||||||||
| libraryDependencies ~= { libs => libs.filterNot(_.name == "groovy-all") } | ||||||||
| libraryDependencies ~= { libs => libs.filterNot(_.name == "groovy-all") }, | ||||||||
| // SPARK-33705: Due to sbt compiler issues, it brings exclusions defined in maven pom back to | ||||||||
| // the classpath directly and assemble test scope artifacts to assembly/target/scala-xx/jars, | ||||||||
| // which is also will be added to the classpath of some unit tests that will build a subprocess | ||||||||
| // to run `spark-submit`, e.g. HiveThriftServer2Test. | ||||||||
| // | ||||||||
| // These artifacts are for the jersey-1 API but Spark use jersey-2 ones, so it cause test | ||||||||
| // flakiness w/ jar conflicts issues. | ||||||||
| // | ||||||||
| // Also jersey-1 is only used by yarn module(see resource-managers/yarn/pom.xml) for testing | ||||||||
| // purpose only. Here we exclude them from the whole project scope and add them w/ yarn only. | ||||||||
| excludeDependencies ++= Seq( | ||||||||
| ExclusionRule(organization = "com.sun.jersey"), | ||||||||
| ExclusionRule("javax.servlet", "javax.servlet-api"), | ||||||||
| ExclusionRule("javax.ws.rs", "jsr311-api")) | ||||||||
yaooqinn marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| ) | ||||||||
| } | ||||||||
|
|
||||||||
|
|
@@ -758,6 +774,15 @@ object Hive { | |||||||
| ) | ||||||||
| } | ||||||||
|
|
||||||||
| object YARN { | ||||||||
| lazy val settings = Seq( | ||||||||
| excludeDependencies --= Seq( | ||||||||
| ExclusionRule(organization = "com.sun.jersey"), | ||||||||
| ExclusionRule("javax.servlet", "javax.servlet-api"), | ||||||||
| ExclusionRule("javax.ws.rs", "jsr311-api")) | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, so in Yarn are we adding
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. THE YARN TESTS relies on this, so I
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it needed only for tests? or during actual runtime with the regular release?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's for test only. FYI, spark/resource-managers/yarn/pom.xml Lines 156 to 158 in 317048d
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this is for test-only, let's include this only for the test scope. It's going to introduce another problem with conflicting jars. Can we try to exclude and include this with test-only scope? If that doesn't work with SBT, that might be fine since we don't use SBT for official release process. We can add documentation for clarification.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just for clarification, we're all fine as long as ...:
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you @yaooqinn.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my pleasure:)
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I filed a JIRA for you: SPARK-34111 :-). |
||||||||
| ) | ||||||||
| } | ||||||||
|
|
||||||||
| object Assembly { | ||||||||
| import sbtassembly.AssemblyUtils._ | ||||||||
| import sbtassembly.AssemblyPlugin.autoImport._ | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this library to
LICENSE-binary. (cc @srowen )