Revert "[SPARK-33504][CORE] The application log in the Spark history server contains sensitive attributes should be redacted" #30576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server contains sensitive attributes should be redacted" This reverts commit e59179b.
Contributor
Author
|
@dongjoon-hyun @akiyamaneko |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Dec 2, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for the quick fix, @tgravescs .
Contributor
Author
|
cores tests passes, I'm going to commit since breaking build |
asfgit
pushed a commit
that referenced
this pull request
Dec 2, 2020
…server contains sensitive attributes should be redacted" ### What changes were proposed in this pull request? Revert SPARK-33504 on branch-3.0 compilation error. Original PR #30446 This reverts commit e59179b. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes #30576 from tgravescs/revert33504. Authored-by: Thomas Graves <[email protected]> Signed-off-by: Thomas Graves <[email protected]>
Member
|
Thanks! |
|
Test build #132069 has finished for PR 30576 at commit
|
Contributor
|
Late LGTM, thanks @tgravescs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert SPARK-33504 on branch-3.0 compilation error. Original PR #30446
This reverts commit e59179b.
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?