Skip to content

Conversation

@xuanyuanking
Copy link
Member

What changes were proposed in this pull request?

As the discussion in #30521 (comment), rename the API to toTable.

Why are the changes needed?

Rename the API for further extension and accuracy.

Does this PR introduce any user-facing change?

Yes, it's an API change but the new API is not released yet.

How was this patch tested?

Existing UT.

@xuanyuanking
Copy link
Member Author

@SparkQA
Copy link

SparkQA commented Dec 2, 2020

Test build #132048 has finished for PR 30571 at commit 724d86a.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@zsxwing zsxwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging to master.

@asfgit asfgit closed this in 878cc0e Dec 3, 2020
@xuanyuanking
Copy link
Member Author

Thanks all!
@HeartSaVioR Do you remind me to change the Jira title to toTable directly? I'm thinking about in the 3.1 release note, we should directly show the final name of the API:

SPARK-32896: Add DataStreamWriter.toTable API

@xuanyuanking xuanyuanking deleted the SPARK-32896-follow branch December 3, 2020 01:38
@HeartSaVioR
Copy link
Contributor

Sure, and looks like it's already taken care. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants