Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 28, 2020

What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules:

  • sql/catalyst
  • sql/hive-thriftserver
  • sql/hive

Split per @srowen #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Why are the changes needed?

Misspelled words make it harder to read / understand content.

Does this PR introduce any user-facing change?

There are various fixes to documentation, etc...

How was this patch tested?

No testing was performed

@github-actions github-actions bot added the SQL label Nov 28, 2020
@jsoref jsoref mentioned this pull request Nov 28, 2020
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hm I wonder if this has any implications elsewhere, like does this affect any non-private generated code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub says maybe: https://github.com/search?q=legacy_setops_precedence_enbled&type=code

I'm going to drop this for now, we can revisit it separately.

@srowen srowen changed the title Spelling sql not core [MINOR] Spelling sql not core Nov 29, 2020
@jsoref jsoref force-pushed the spelling-sql-not-core branch from e225da9 to f77c773 Compare November 29, 2020 01:09
@srowen
Copy link
Member

srowen commented Nov 30, 2020

Looking OK, just needs a rebase

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref force-pushed the spelling-sql-not-core branch from f77c773 to 1f9f1bb Compare November 30, 2020 17:49
@maropu
Copy link
Member

maropu commented Dec 1, 2020

Jenkins is down now, so could you re-invoke the GA tests?

@srowen
Copy link
Member

srowen commented Dec 3, 2020

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Test build #132139 has finished for PR 30532 at commit 1f9f1bb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36740/

@SparkQA
Copy link

SparkQA commented Dec 3, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36740/

@srowen
Copy link
Member

srowen commented Dec 4, 2020

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36775/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Test build #132174 has finished for PR 30532 at commit 1f9f1bb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36775/

@srowen
Copy link
Member

srowen commented Dec 4, 2020

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Test build #132234 has finished for PR 30532 at commit 1f9f1bb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36834/

@SparkQA
Copy link

SparkQA commented Dec 4, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36834/

@maropu
Copy link
Member

maropu commented Dec 7, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36909/

@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36909/

@SparkQA
Copy link

SparkQA commented Dec 7, 2020

Test build #132309 has finished for PR 30532 at commit 1f9f1bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in c62b84a Dec 7, 2020
@srowen
Copy link
Member

srowen commented Dec 7, 2020

Merged to master

@jsoref jsoref deleted the spelling-sql-not-core branch December 7, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants