Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 28, 2020

What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules:

  • bin
  • core
  • docs
  • external
  • mllib
  • repl
  • pom.xml

Split per @srowen #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Why are the changes needed?

Misspelled words make it harder to read / understand content.

Does this PR introduce any user-facing change?

There are various fixes to documentation, etc...

How was this patch tested?

No testing was performed

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; I had a few very minor additional changes to suggest

@srowen srowen changed the title Spelling bin core docs external mllib repl [MINOR] Spelling bin core docs external mllib repl Nov 29, 2020
@jsoref jsoref force-pushed the spelling-bin-core-docs-external-mllib-repl branch from 3877692 to f9bb755 Compare November 29, 2020 01:07
@kiszk
Copy link
Member

kiszk commented Nov 29, 2020

Could you please address the following typos, too?

docs/configuration.md
excluded -> excluded

docs/graphx-programming-guide.md
an `VertexRDD -> a `VertexRDD (2 places)

docs/mllib-clustering.md
an `JavaRDD -> a \JavaRDD`

docs/mllib-data-types.md
an CoordinateMatrix -> a CoordinateMatrix

docs/running-on-kubernetes.md and docs/running-on-yarn.md
propogate -> propagate (2 places)

docs/sql-ref-syntax-qry-select-groupby.md
column -> column (3 places)

docs/sql-ref-syntax-qry-select-lateral-view.md
tabelName -> tableName (3 places)

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref force-pushed the spelling-bin-core-docs-external-mllib-repl branch from f9bb755 to 295f588 Compare November 29, 2020 18:48
@jsoref
Copy link
Contributor Author

jsoref commented Nov 29, 2020

@kiszk: done (not quite sure how I missed tabel)

@srowen
Copy link
Member

srowen commented Nov 29, 2020

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Nov 29, 2020

Test build #131934 has finished for PR 30530 at commit 295f588.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Nov 30, 2020

Thanks

@maropu
Copy link
Member

maropu commented Nov 30, 2020

Thanks! Merged to master.

@maropu maropu closed this in 4851453 Nov 30, 2020
@jsoref jsoref deleted the spelling-bin-core-docs-external-mllib-repl branch November 30, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants