[MINOR][SQL] Remove getTables() from r.SQLUtils#30527
Closed
MaxGekk wants to merge 3 commits intoapache:masterfrom
Closed
[MINOR][SQL] Remove getTables() from r.SQLUtils#30527MaxGekk wants to merge 3 commits intoapache:masterfrom
getTables() from r.SQLUtils#30527MaxGekk wants to merge 3 commits intoapache:masterfrom
Conversation
|
Test build #131908 has finished for PR 30527 at commit
|
|
Test build #131909 has finished for PR 30527 at commit
|
|
Test build #131912 has finished for PR 30527 at commit
|
dongjoon-hyun
approved these changes
Nov 29, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for the investigation and clean-up, @MaxGekk .
Merged to master for Apache Spark 3.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the unused method
getTables()fromr.SQLUtils. The method was used before the changes #17483 but R'stables.defaultwas rewritten usinglistTables(): https://github.com/apache/spark/pull/17483/files#diff-2c01472a7bcb1d318244afcd621d726e00d36cd15dffe7e44fa96c54fce4cd9aR220-R223Why are the changes needed?
To improve code maintenance, and remove the dead code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By R tests.