[SPARK-32915][SHUFFLE] Create and rename classes in shuffle RPC used for block push operations #30513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… push. Add BlockPushingListener for block push.
Contributor
Author
Contributor
Author
|
@tgravescs @attilapiros @Ngone51 @mridulm @jiangxb1987 this is a follow up to #29855 to rename classes reused across both block fetch and push as promised. |
Contributor
|
ok to test |
|
Test build #131999 has finished for PR 30513 at commit
|
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up to #29855 according to the comments
In this PR, the following changes are made:
BlockPushingListenerinterface is created specifically for block push, and the existingBlockFetchingListenerinterface is left backward compatible. These 2 interfaces are unified underBlockTransferListenerto enable code reuse.RetryingBlockFetcher,BlockFetchStarter, andRetryingBlockFetchListenerare renamed toRetryingBlockTransferor,BlockTransferStarter, andRetryingBlockTransferListenerrespectively. This makes their names more generic to be reused across both block fetch and push.OneForOneBlockPusherare further clarified to better explain how we handle retries for block push.Why are the changes needed?
To make code cleaner without sacrificing backward compatibility.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests.