Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Nov 25, 2020

What changes were proposed in this pull request?

The purpose of this PR is to extract the common tests for v1 and v2 ALTER TABLE .. PARTITION, and run them for both DSv1 and DSv2.

This PR follows the approach for SHOW TABLES and SHOW PARTITIONS:

Why are the changes needed?

  1. To improve test coverage of v1 and v2 implementations of ALTER TABLE .. PARTITION commands.
  2. To improve tests maintainability.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By running new test suites:

  • AlterTablePartitionParserSuite
  • v2/AlterTablePartitionSuite

@github-actions github-actions bot added the SQL label Nov 25, 2020
@SparkQA
Copy link

SparkQA commented Nov 25, 2020

Test build #131773 has finished for PR 30499 at commit 3abb93d.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 25, 2020

Test build #131781 has finished for PR 30499 at commit 665d7d8.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MaxGekk
Copy link
Member Author

MaxGekk commented Dec 9, 2020

Replaced by #30685

@MaxGekk MaxGekk closed this Dec 9, 2020
@MaxGekk MaxGekk deleted the unify-dsv1_v2-alter-table-partition-tests branch February 19, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants