-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-33526][SQL] Add config to control if cancel invoke interrupt task on thriftserver #30481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
9b54da6
ba382a3
911da70
d1ebbba
de89232
9a05f0b
f8d6384
cd54e48
c9c5cd3
921f9cf
99ec864
0466c0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -932,11 +932,20 @@ object SQLConf { | |
| "a positive value, a running query will be cancelled automatically when the timeout is " + | ||
| "exceeded, otherwise the query continues to run till completion. If timeout values are " + | ||
| "set for each statement via `java.sql.Statement.setQueryTimeout` and they are smaller " + | ||
| "than this configuration value, they take precedence.") | ||
| "than this configuration value, they take precedence. After set this config, you may be " + | ||
| "interesting in spark.sql.thriftServer.interruptOnCancel which can help interrupt task.") | ||
|
HyukjinKwon marked this conversation as resolved.
Outdated
HyukjinKwon marked this conversation as resolved.
Outdated
|
||
| .version("3.1.0") | ||
| .timeConf(TimeUnit.SECONDS) | ||
| .createWithDefault(0L) | ||
|
|
||
| val THRIFTSERVER_FORCE_CANCEL = | ||
| buildConf("spark.sql.thriftServer.interruptOnCancel") | ||
| .doc("When true, all running tasks will be interrupted if one cancels a query. " + | ||
| "When false, all running tasks will be remained until finished.") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shall we guide users to enable this configuration when
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah It sounds so warm !
HyukjinKwon marked this conversation as resolved.
Outdated
|
||
| .version("3.2.0") | ||
| .booleanConf | ||
| .createWithDefault(false) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't aware that cancelling a job group leaves currently running tasks running to completion.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The reason is same with |
||
|
|
||
| val THRIFTSERVER_UI_STATEMENT_LIMIT = | ||
| buildConf("spark.sql.thriftserver.ui.retainedStatements") | ||
| .doc("The number of SQL statements kept in the JDBC/ODBC web UI history.") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.