Skip to content

Conversation

@sryza
Copy link
Contributor

@sryza sryza commented Oct 31, 2014

No description provided.

@JoshRosen
Copy link
Contributor

/cc @kayousterhout are there other places where we need to update this?

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22650 has started for PR 3043 at commit e327340.

  • This patch merges cleanly.

@kayousterhout
Copy link
Contributor

LGTM -- I'll merge this when the tests finish. Thanks for fixing this Sandy!

@kayousterhout
Copy link
Contributor

@JoshRosen I think this is the only place where it's broken; all other uses of metrics.get that I added are in creating the summary table, and there, the tasks without task metrics have already been filtered out.

@andrewor14
Copy link
Contributor

LGTM. At some point we should try to understand why metrics can be None sometimes. I've noticed many entries in a task row going blank before.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22650 has finished for PR 3043 at commit e327340.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22650/
Test PASSed.

@kayousterhout
Copy link
Contributor

github seems to be slow to update, but I've merged this into master. Thanks Sandy!!

@asfgit asfgit closed this in 23f73f5 Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants