Skip to content

[SPARK-33483][INFRA][TESTS] Fix rat exclusion patterns and add a LICENSE #30418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-33483][INFRA][TESTS] Fix rat exclusion patterns and add a LICENSE #30418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d35ad4
[MINOR][INFRA] Fix rat exclusion not to exclude `catalog`
dongjoon-hyun Nov 19, 2020
45658f0
Fix more
dongjoon-hyun Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions dev/.rat-excludes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ jquery.dataTables.1.10.20.min.js
jquery.mustache.js
jsonFormatter.min.css
jsonFormatter.min.js
.*avsc
.*txt
.*json
.*data
.*log
.*\.avsc
.*\.txt
.*\.json
.*\.data
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides the directory data and metadata.

.*\.log
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides catalog directory.

pyspark-coverage-site/*
cloudpickle/*
join.py
Expand Down Expand Up @@ -98,17 +98,17 @@ local-1430917381535_2
DESCRIPTION
NAMESPACE
test_support/*
.*Rd
.*\.Rd
help/*
html/*
INDEX
.lintr
gen-java.*
.*avpr
.*parquet
.*\.avpr
.*\.parquet
spark-deps-.*
.*csv
.*tsv
.*\.csv
.*\.tsv
.*\.sql
.Rbuildignore
META-INF/*
Expand All @@ -125,3 +125,11 @@ application_1578436911597_0052
config.properties
app-20200706201101-0003
py.typed
_metadata
_SUCCESS
part-00000
.*\.res
flights_tiny.txt.1
over1k
over10k
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I checked these are .txt

exported_table/*
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is .q

18 changes: 18 additions & 0 deletions sql/hive/src/test/resources/data/scripts/test_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a JIRA because I touch this file inevitabily.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this change, we need to wait for the full test result of GitHub Action.

import sys

delim = sys.argv[1]
Expand Down