[SPARK-33427][SQL][FOLLOWUP] Prevent test flakyness in SubExprEvaluationRuntimeSuite #30414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
maropu
approved these changes
Nov 19, 2020
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
HyukjinKwon
approved these changes
Nov 19, 2020
Member
Author
|
Thanks. GA was passed. Merging to master. |
Member
|
+1, late LGTM. |
|
Test build #131308 has finished for PR 30414 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This followup is to prevent possible test flakyness of
SubExprEvaluationRuntimeSuite.Why are the changes needed?
Because HashMap doesn't guarantee the order, in
proxyExpressionsthe proxy expression id is not deterministic. So inSubExprEvaluationRuntimeSuitewe should not test against it.Does this PR introduce any user-facing change?
No, dev only.
How was this patch tested?
Unit test.