Skip to content

[SPARK-32852][SQL][Doc][Followup] Revise the documentation of spark.sql.hive.metastore.jars #30407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gengliangwang wants to merge 5 commits into from
Closed

[SPARK-32852][SQL][Doc][Followup] Revise the documentation of spark.sql.hive.metastore.jars #30407

gengliangwang wants to merge 5 commits into from

Conversation

@gengliangwang
Copy link
Member

@gengliangwang gengliangwang commented Nov 18, 2020 •
edited
Loading

What changes were proposed in this pull request?

This is a follow-up for #29881.
It revises the documentation of the configuration spark.sql.hive.metastore.jars.

Why are the changes needed?

Fix grammatical error in the doc.
Also, make it more clear that the configuration is effective only when spark.sql.hive.metastore.jars is set as path

Does this PR introduce any user-facing change?

No

How was this patch tested?

Just doc changes.

@gengliangwang
Copy link
Member Author

gengliangwang commented Nov 18, 2020

cc @AngersZhuuuu @cloud-fan

@gengliangwang gengliangwang changed the title [SPARK-32852][Doc] Revise the documentation of spark.sql.hive.metastore.jars [SPARK-32852][SQL][Doc] Revise the documentation of spark.sql.hive.metastore.jars Nov 18, 2020
@gengliangwang gengliangwang changed the title [SPARK-32852][SQL][Doc] Revise the documentation of spark.sql.hive.metastore.jars [SPARK-32852][SQL][Doc][Followup] Revise the documentation of spark.sql.hive.metastore.jars Nov 18, 2020
AngersZhuuuu
AngersZhuuuu approved these changes Nov 18, 2020
View reviewed changes
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
| Note that 1, 2, and 3 support wildcard. For example:
| 1. file://path/to/jar/*,file://path2/to/jar/*/*.jar
| 2. hdfs://nameservice/path/to/jar/*,hdfs://nameservice2/path/to/jar/*/*.jar
""".stripMargin)
Copy link
Contributor

@AngersZhuuuu AngersZhuuuu Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131267 has finished for PR 30407 at commit 93c7d10.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131264 has finished for PR 30407 at commit b07b135.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131265 has finished for PR 30407 at commit 8abc00f.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131269 has finished for PR 30407 at commit d7f040c.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@github-actions github-actions bot added the SQL label Nov 18, 2020
@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35867/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35868/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35868/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35867/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35870/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131272 has finished for PR 30407 at commit 45922bd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35870/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35872/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35874/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35872/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35874/

@gengliangwang
Copy link
Member Author

gengliangwang commented Nov 18, 2020 •
edited
Loading

@dongjoon-hyun @AngersZhuuuu @cloud-fan Thanks for the review

@gengliangwang
Copy link
Member Author

gengliangwang commented Nov 18, 2020

Merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fan cloud-fan cloud-fan approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

+1 more reviewer

@AngersZhuuuu AngersZhuuuu AngersZhuuuu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gengliangwang @SparkQA @cloud-fan @dongjoon-hyun @AngersZhuuuu