Skip to content

Conversation

@maropu
Copy link
Member

@maropu maropu commented Nov 18, 2020

What changes were proposed in this pull request?

This PR intends to upgrade ANTLR runtime from 4.7.1 to 4.8-1.

Why are the changes needed?

Release note of v4.8 and v4.7.2 (the v4.7.2 release has a few minor bug fixes for java targets):

Does this PR introduce any user-facing change?

No.

How was this patch tested?

GA tests.

@HyukjinKwon
Copy link
Member

cc @hvanhovell FYI

@github-actions github-actions bot added the BUILD label Nov 18, 2020
@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35851/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35851/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131248 has finished for PR 30404 at commit e28ef62.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@hvanhovell hvanhovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

Late LGTM. Thank you all.

@HyukjinKwon
Copy link
Member

Just quick question:

Do you guys know the diff between 4.8-1 vs 4.8? The official release seems to be 4.8 https://www.antlr.org/download/index.html - I checked the pom files and jars too.

@HyukjinKwon
Copy link
Member

Maybe let's just use the 4.8 that's matched with the official releases there ...

Thanks for pointing this out, @bozhang2820. Mind making a quick followup to match this to 4.8?

@bozhang2820
Copy link
Contributor

Maybe let's just use the 4.8 that's matched with the official releases there ...

Thanks for pointing this out, @bozhang2820. Mind making a quick followup to match this to 4.8?

Sure. Created #32603.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants