Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 17, 2020

What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules:

  • R
  • common
  • dev
  • mlib
  • external
  • project
  • streaming
  • resource-managers
  • python

Split per @srowen #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Why are the changes needed?

Misspelled words make it harder to read / understand content.

Does this PR introduce any user-facing change?

There are various fixes to documentation, etc...

How was this patch tested?

No testing was performed

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think this is fine pending tests. I wouldn't backport, myself.

@jsoref jsoref force-pushed the spelling-R_common_dev_mlib_external_project_streaming_resource-managers_python branch from de3746c to 3a1fc3c Compare November 17, 2020 23:27
@jsoref jsoref mentioned this pull request Nov 19, 2020
@srowen
Copy link
Member

srowen commented Nov 19, 2020

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Nov 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35959/

@SparkQA
Copy link

SparkQA commented Nov 19, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35959/

@SparkQA
Copy link

SparkQA commented Nov 19, 2020

Test build #131354 has finished for PR 30402 at commit 3a1fc3c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 20, 2020

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Nov 20, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35994/

@SparkQA
Copy link

SparkQA commented Nov 20, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35994/

@SparkQA
Copy link

SparkQA commented Nov 20, 2020

Test build #131390 has finished for PR 30402 at commit 3a1fc3c.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 22, 2020

@jsoref when you get a chance, rebase this one so we can rerun tests

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@jsoref jsoref force-pushed the spelling-R_common_dev_mlib_external_project_streaming_resource-managers_python branch from 3a1fc3c to 070e6bb Compare November 22, 2020 19:29
@srowen
Copy link
Member

srowen commented Nov 24, 2020

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Nov 24, 2020

Test build #131685 has finished for PR 30402 at commit 070e6bb.

  • This patch fails R style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 26, 2020

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Nov 26, 2020

Test build #131851 has finished for PR 30402 at commit 070e6bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 27, 2020

Merged to master

@srowen srowen closed this in 13fd272 Nov 27, 2020
@srowen srowen changed the title Spelling r common dev mlib external project streaming resource managers python [MINOR] Spelling r common dev mlib external project streaming resource managers python Nov 27, 2020
@jsoref jsoref deleted the spelling-R_common_dev_mlib_external_project_streaming_resource-managers_python branch November 27, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants