-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[MINOR][SQL][DOCS] Update schema_of_csv and schema_of_json doc #30396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fix Python API? or it supports only literals?
spark/python/pyspark/sql/functions.py
Line 3530 in 4c8ee88
a JSON string or a string literal containing a JSON string. spark/python/pyspark/sql/functions.py
Line 3567 in 4c8ee88
a CSV string or a string literal containing a CSV string.
|
Test build #131212 has finished for PR 30396 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM (except @MaxGekk 's comments).
|
Kubernetes integration test starting |
|
Let me just merge this in. All relevant tests such as build and linters passed |
|
Merged to master. |
|
Thanks all! |
|
Kubernetes integration test status success |
|
Test build #131239 has finished for PR 30396 at commit
|
What changes were proposed in this pull request?
This minor PR updates the docs of
schema_of_csvandschema_of_json. They allow foldable string column instead of a string literal now.Why are the changes needed?
The function doc of
schema_of_csvandschema_of_jsonare not updated accordingly with previous PRs.Does this PR introduce any user-facing change?
Yes, update user-facing doc.
How was this patch tested?
Unit test.