Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Nov 17, 2020

What changes were proposed in this pull request?

This minor PR updates the docs of schema_of_csv and schema_of_json. They allow foldable string column instead of a string literal now.

Why are the changes needed?

The function doc of schema_of_csv and schema_of_json are not updated accordingly with previous PRs.

Does this PR introduce any user-facing change?

Yes, update user-facing doc.

How was this patch tested?

Unit test.

@viirya
Copy link
Member Author

viirya commented Nov 17, 2020

cc @HyukjinKwon @cloud-fan

@github-actions github-actions bot added the SQL label Nov 17, 2020
@SparkQA
Copy link

SparkQA commented Nov 17, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35815/

@SparkQA
Copy link

SparkQA commented Nov 17, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35815/

Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fix Python API? or it supports only literals?

@SparkQA
Copy link

SparkQA commented Nov 17, 2020

Test build #131212 has finished for PR 30396 at commit 29a3e0b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (except @MaxGekk 's comments).

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][SQL] Update schema_of_csv and schema_of_json doc [MINOR][SQL][DOCS] Update schema_of_csv and schema_of_json doc Nov 17, 2020
@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35843/

@HyukjinKwon
Copy link
Member

Let me just merge this in. All relevant tests such as build and linters passed

@HyukjinKwon
Copy link
Member

Merged to master.

@viirya
Copy link
Member Author

viirya commented Nov 18, 2020

Thanks all!

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35843/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131239 has finished for PR 30396 at commit 1224ba9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya viirya deleted the minor-json-csv branch December 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants