Skip to content

Conversation

@ravipesala
Copy link
Contributor

if the query contains "not between" does not work like.
SELECT * FROM src where key not between 10 and 20'

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22540 has started for PR 3017 at commit 805eebc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22540 has finished for PR 3017 at commit 805eebc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22540/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Nit, but if you have to break the line I think it should be formatted as:

And(
  GreaterThanOrEqual(targetExpression, nodeToExpr(minValue)),
  LessThanOrEqual(targetExpression, nodeToExpr(maxValue)))

This way the tree structure is more clear.

@marmbrus
Copy link
Contributor

Other than a very minor formatting issue LGTM.

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22612 has started for PR 3017 at commit 65fc89e.

  • This patch merges cleanly.

@ravipesala
Copy link
Contributor Author

Thank you for your comment.I handled it and also rebased with master.Please review it

@SparkQA
Copy link

SparkQA commented Oct 31, 2014

Test build #22612 has finished for PR 3017 at commit 65fc89e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22612/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to master.

@asfgit asfgit closed this in ea465af Oct 31, 2014
@ravipesala ravipesala deleted the SPARK-4154 branch November 1, 2014 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants