-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-4154][SQL] Query does not work if it has "not between " in Spark SQL and HQL #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
ok to test |
|
Test build #22540 has started for PR 3017 at commit
|
|
Test build #22540 has finished for PR 3017 at commit
|
|
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Nit, but if you have to break the line I think it should be formatted as:
And(
GreaterThanOrEqual(targetExpression, nodeToExpr(minValue)),
LessThanOrEqual(targetExpression, nodeToExpr(maxValue)))This way the tree structure is more clear.
|
Other than a very minor formatting issue LGTM. |
805eebc to
65fc89e
Compare
|
Test build #22612 has started for PR 3017 at commit
|
|
Thank you for your comment.I handled it and also rebased with master.Please review it |
|
Test build #22612 has finished for PR 3017 at commit
|
|
Test PASSed. |
|
Thanks! Merged to master. |
if the query contains "not between" does not work like.
SELECT * FROM src where key not between 10 and 20'