[SPARK-33136][SQL][2.4] Fix mistakenly swapped parameter in V2WriteCommand.outputResolved #30043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WriteCommand.outputResolved
Contributor
Author
|
cc. @dongjoon-hyun |
Member
|
Thank you so much, @HeartSaVioR ! |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Oct 15, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to branch-2.4
dongjoon-hyun
pushed a commit
that referenced
this pull request
Oct 15, 2020
…mmand.outputResolved ### What changes were proposed in this pull request? This PR proposes to fix a bug on calling `DataType.equalsIgnoreCompatibleNullability` with mistakenly swapped parameters in `AppendData.outputResolved`. The order of parameters for `DataType.equalsIgnoreCompatibleNullability` are `from` and `to`, which says that the right order of matching variables are `inAttr` and `outAttr`. ### Why are the changes needed? Although the problematic part is a dead code, once we know there's a bug, preferably we'd like to fix that. ### Does this PR introduce _any_ user-facing change? No, as this fixes the dead code. ### How was this patch tested? This patch fixes the dead code, which is not easy to craft a test. (The test in original commit is no longer valid here.) Closes #30043 from HeartSaVioR/SPARK-33136-branch-2.4. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan.opensource@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Contributor
Author
|
Thanks for reviewing and merging! |
|
Test build #129785 has finished for PR 30043 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to fix a bug on calling
DataType.equalsIgnoreCompatibleNullabilitywith mistakenly swapped parameters inAppendData.outputResolved. The order of parameters forDataType.equalsIgnoreCompatibleNullabilityarefromandto, which says that the right order of matching variables areinAttrandoutAttr.Why are the changes needed?
Although the problematic part is a dead code, once we know there's a bug, preferably we'd like to fix that.
Does this PR introduce any user-facing change?
No, as this fixes the dead code.
How was this patch tested?
This patch fixes the dead code, which is not easy to craft a test. (The test in original commit is no longer valid here.)