[SPARK-33026][SQL][followup] metrics name should be numOutputRows #30039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Oct 14, 2020
| val dataSize = metrics("dataSize").value | ||
| val numRows = metrics("numRows").value | ||
| Statistics(dataSize, Some(numRows)) | ||
| val rowCount = metrics("numOutputRows").value |
Contributor
Author
There was a problem hiding this comment.
match Statistics.rowCount
cloud-fan
commented
Oct 14, 2020
| val beforeCollect = System.nanoTime() | ||
| // Use executeCollect/executeCollectIterator to avoid conversion to Scala types | ||
| val (numRows, input) = child.executeCollectIterator() | ||
| longMetric("numOutputRows") += numRows |
Contributor
Author
There was a problem hiding this comment.
always set the metrics even if failure happens.
Contributor
Author
|
cc @wangyum |
wangyum
approved these changes
Oct 14, 2020
Member
wangyum
left a comment
wangyum
left a comment
There was a problem hiding this comment.
Yes, I also considered using numOutputRows at the time. I didn’t use it because ShuffleExchange didn’t use numOutputRows either.
Contributor
Author
|
thanks for the review! GA passed, merging to master. |
Member
|
Thank you, @cloud-fan . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow the convention and rename the metrics
numRowstonumOutputRowsWhy are the changes needed?
FilterExec,HashAggregateExec, etc. all usenumOutputRowsDoes this PR introduce any user-facing change?
no
How was this patch tested?
existing tests