[SPARK-33125][SQL] Improve the error when Lead and Lag are not allowed to specify window frame #30021
Conversation
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
Show resolved
Hide resolved
| if wf.frame != UnspecifiedFrame && wf.frame != f => | ||
| failAnalysis(s"Window Frame $f must match the required frame ${wf.frame}") | ||
| case WindowExpression(owf: OffsetWindowFunction, | ||
| WindowSpecDefinition(_, _, _: SpecifiedWindowFrame)) => |
There was a problem hiding this comment.
OffsetWindowFunction can use UnspecifiedFrame now?
|
Kubernetes integration test starting |
|
Test build #129723 has finished for PR 30021 at commit
|
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Test build #129725 has finished for PR 30021 at commit
|
|
Kubernetes integration test status success |
|
Test build #129730 has finished for PR 30021 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #129732 has finished for PR 30021 at commit
|
|
thanks, merging to master! |
|
@cloud-fan Thanks for your help! |
3 participants
What changes were proposed in this pull request?
Except for Postgresql, other data sources (for example: vertica, oracle, redshift, mysql, presto) are not allowed to specify window frame for the Lead and Lag functions.
But the current error message is not clear enough.
Window Frame $f must match the required frameThis PR will use the following error message.
Cannot specify window frame for lead functionWhy are the changes needed?
Make clear error message.
Does this PR introduce any user-facing change?
Yes
Users will see the clearer error message.
How was this patch tested?
Jenkins test.