[WIP][SPARK-33098][SQL] Fix In expression casts #29988
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
InConversionrule by finding the common wider type of list expressions first and then the final common type for comparison between the value and the list expressions.Before this PR the query
SELECT * FROM t WHERE c IN ('2')where c isIntgenerated the following filter:After this PR it generates:
that is identical to what a
WHERE c = '2'would do.Why are the changes needed?
To make
Inbehave like=and avoid issues described in https://issues.apache.org/jira/browse/SPARK-33098Does this PR introduce any user-facing change?
Yes, some queries will not fail.
How was this patch tested?
Existing UTs and I will add some new ones as well.