Skip to content

[SPARK-33040][FOLLOW-UP][R] Reorder argument choices and add examples#29944

Closed
zero323 wants to merge 2 commits intoapache:masterfrom
zero323:SPARK-33040-FOLLOW-UP
Closed

[SPARK-33040][FOLLOW-UP][R] Reorder argument choices and add examples#29944
zero323 wants to merge 2 commits intoapache:masterfrom
zero323:SPARK-33040-FOLLOW-UP

Conversation

@zero323
Copy link
Copy Markdown
Member

@zero323 zero323 commented Oct 5, 2020

What changes were proposed in this pull request?

  • Reorder choices of dtype to match Scala defaults.
  • Add example to ml_functions.

Why are the changes needed?

As requested:

Does this PR introduce any user-facing change?

No (changes to newly added component).

How was this patch tested?

Existing tests.

@zero323
Copy link
Copy Markdown
Member Author

zero323 commented Oct 5, 2020

cc @HyukjinKwon

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 5, 2020

Test build #129401 has finished for PR 29944 at commit 71eeace.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 5, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34008/

@SparkQA
Copy link
Copy Markdown

SparkQA commented Oct 5, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34008/

@HyukjinKwon
Copy link
Copy Markdown
Member

Merged to master.

@zero323
Copy link
Copy Markdown
Member Author

zero323 commented Oct 5, 2020

Thanks @HyukjinKwon

@zero323 zero323 deleted the SPARK-33040-FOLLOW-UP branch October 5, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants