[SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context#29918
Closed
reidy-p wants to merge 2 commits intoapache:masterfrom
Closed
[SPARK-33017][PYTHON] Add getCheckpointDir method to PySpark Context#29918reidy-p wants to merge 2 commits intoapache:masterfrom
reidy-p wants to merge 2 commits intoapache:masterfrom
Conversation
HyukjinKwon
reviewed
Oct 2, 2020
Member
|
ok to test |
|
Test build #129335 has finished for PR 29918 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #129392 has finished for PR 29918 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
zero323
approved these changes
Oct 4, 2020
HyukjinKwon
approved these changes
Oct 5, 2020
Member
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Oct 7, 2020
…documentation ### What changes were proposed in this pull request? This is a followup of #29918. We should add it into the documentation as well. ### Why are the changes needed? To show users new APIs. ### Does this PR introduce _any_ user-facing change? Yes, `SparkContext.getCheckpointDir` will be documented. ### How was this patch tested? Manually built the PySpark documentation: ```bash cd python/docs make clean html cd build/html open index.html ``` Closes #29960 from HyukjinKwon/SPARK-33017. Authored-by: HyukjinKwon <gurwls223@apache.org> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding a method to get the checkpoint directory from the PySpark context to match the Scala API
Why are the changes needed?
To make the Scala and Python APIs consistent and remove the need to use the JavaObject
Does this PR introduce any user-facing change?
Yes, there is a new method which makes it easier to get the checkpoint directory directly rather than using the JavaObject
Previous behaviour:
This method returns a confusing Scala error if it has not been set
New method:
getCheckpointDir()returnsNoneif it has not been setHow was this patch tested?
Added to existing unit tests. But I'm not sure how to add a test for the case where
getCheckpointDir()should returnNonesince the existing checkpoint tests set the checkpoint directory in thesetUpmethod before any tests are run as far as I can tell.