[SPARK-32971][K8S][FOLLOWUP] Fix k8s-core module compilation in Scala 2.13 #29861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @dongjoon-hyun The change of SPARK-32971 blocking GitHub 2.13 build Action |
LuciferYang
changed the title
LuciferYang
changed the title
Contributor
Author
|
also ping @HyukjinKwon |
Member
|
|
|
|
||
| override def getAdditionalKubernetesResources(): Seq[HasMetadata] = { | ||
| additionalResources | ||
| additionalResources.toSeq |
Member
There was a problem hiding this comment.
|
Kubernetes integration test starting |
Member
|
Please reopen this if the master branch is broken really. |
Contributor
Author
|
@dongjoon-hyun ok, I found #29859 fix this today :) |
Member
|
:) |
|
Kubernetes integration test status success |
|
Test build #129061 has finished for PR 29861 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Manual call
toSeqofMountVolumesFeatureStep.getAdditionalKubernetesResourcesmethod becauseArrayBuffernot aSeqin Scala 2.13Why are the changes needed?
We need to support a Scala 2.13 build.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Scala 2.12: Pass the Jenkins or GitHub Action
Scala 2.13: Pass GitHub 2.13 Build Action