[HOTFIX][2.4] Revert SPARK-32886 #29825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew" This reverts commit 2516128.
Member
Author
|
Test build #128944 has finished for PR 29825 at commit
|
Member
Author
|
retest this please. |
|
Test build #128945 has finished for PR 29825 at commit
|
Member
|
Ah OK, yes let's revert. Feel free to open another PR for branch-2.4 if you're up for it. The test failure is not related, and another instance of a corrupt Maven dir on Jenkins. @shaneknapp can that be deleted? So, I'm pretty OK to revert this right away as it clearly passed before the original change. |
asfgit
pushed a commit
that referenced
this pull request
Sep 21, 2020
### What changes were proposed in this pull request? This PR reverts SPARK-32886 (#29757) for branch-2.4. That change needs `appBasePath` in `webui.js` but it's absent for `branch-2.4`. Closes #29825 from sarutak/hotfix-for-SPARK-32886-2.4. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
Member
Author
|
@srowen Thanks. I've reverted it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts SPARK-32886 (#29757) for branch-2.4.
That change needs
appBasePathinwebui.jsbut it's absent forbranch-2.4.