Skip to content

[SPARK-32886][WEBUI] fix 'undefined' link in event timeline view #29757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhli1142015 wants to merge 4 commits into from
Closed

[SPARK-32886][WEBUI] fix 'undefined' link in event timeline view #29757

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
970c2f5
fix 'undefined' link in event timeline view
zhli1142015 Sep 15, 2020
00f5c60
minor change
zhli1142015 Sep 15, 2020
b243dc3
address comments
zhli1142015 Sep 15, 2020
40d94f6
minor change
zhli1142015 Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/main/resources/org/apache/spark/ui/static/timeline-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,18 @@ function drawApplicationTimeline(groupArray, eventObjArray, startTime, offset) {
return "#job-" + jobId;
};

var getPathForJobEntry = function(baseElem) {

@srowen srowen Sep 15, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal but why not just inline this?

@zhli1142015 zhli1142015 Sep 15, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srowen . Yes, this is good idea, updated.

var jobIdText = $($(baseElem).find(".application-timeline-content")[0]).text();
var jobId = jobIdText.match("\\(Job (\\d+)\\)$")[1];

@sarutak sarutak Sep 15, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobIdText and jobId are calculated here so can we reuse them to avoid additional overhead of jQuery selector and regex?

@zhli1142015 zhli1142015 Sep 16, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comments. i extracted common function getIdForJobEntry for selector and regex, and moved it out of each loop. It is only triggered by click and hover events. i think this is ok here.

return "job/?id=" + jobId;
};

$(this).click(function() {
var jobPagePath = $(getSelectorForJobEntry(this)).find("a.name-link").attr("href");
window.location.href = jobPagePath
if (jobPagePath == undefined) {

@sarutak sarutak Sep 15, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this if branch?
If we can unify the two pieces of code for jobPagePath with the new logic, can we remove away this if branch?

@zhli1142015 zhli1142015 Sep 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarutak . we should remove it and use new logic, updated.

jobPagePath = getPathForJobEntry(this)
}
window.location.href = jobPagePath
});

$(this).hover(
Expand Down