Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Sep 13, 2020

What changes were proposed in this pull request?

This PR changes SparkBuild.scala to ignore deprecation warnings for build with Scala 2.13 and sbt.
Actually, deprecation warnings are already ignored for Scala 2.12 but string matching logic for deprecation warnings should be changed for Scala 2.13.
Currently, if a warning message contains is deprecated, it's ignored but some warnings contain "are deprecatedandwill be deprecated`.

[error] [warn] /home/kou/work/oss/spark-scala-2.13/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:656: multiarg infix syntax looks\
 like a tuple and will be deprecated                                                                                                              
[error] [warn]         if (opt.clOption != null) { childArgs += (opt.clOption, opt.value) } 
[error] [warn] /home/kou/work/oss/spark-scala-2.13/core/src/main/scala/org/apache/spark/rdd/SequenceFileRDDFunctions.scala:35: view bounds are de\
precated; use an implicit parameter instead.                                                                                                      
[error]   example: instead of `def f[A <% Int](a: A)` use `def f[A](a: A)(implicit ev: A => Int)`                                                 
[error] [warn] class SequenceFileRDDFunctions[K <% Writable: ClassTag, V <% Writable : ClassTag](   

Why are the changes needed?

Enable to build Spark with Scala 2.13 and sbt.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Build with the following command and confirmed deprecation warnings are not treated as fatal ( Build itself doesn't pass due to another problem).
build/sbt -Pscala-2.13 package

@SparkQA
Copy link

SparkQA commented Sep 13, 2020

Test build #128603 has finished for PR 29741 at commit fdfab03.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants