[SPARK-32865][DOC] python section in quickstart page doesn't display SPARK_VERSION correctly #29738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SPARK_VERSION correctly
Member
|
ok to test |
dongjoon-hyun
approved these changes
Sep 13, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @bowenli86 .
Merged to master/3.0/2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 13, 2020
…SPARK_VERSION correctly ### What changes were proposed in this pull request? In https://github.com/apache/spark/blame/master/docs/quick-start.md#L402,it should be `{{site.SPARK_VERSION}}` rather than `{site.SPARK_VERSION}` ### Why are the changes needed? SPARK_VERSION isn't displayed correctly, as shown below  ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested locally, as shown below  Closes #29738 from bowenli86/doc. Authored-by: bowen.li <bowenli86@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0549c20) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 13, 2020
…SPARK_VERSION correctly ### What changes were proposed in this pull request? In https://github.com/apache/spark/blame/master/docs/quick-start.md#L402,it should be `{{site.SPARK_VERSION}}` rather than `{site.SPARK_VERSION}` ### Why are the changes needed? SPARK_VERSION isn't displayed correctly, as shown below  ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested locally, as shown below  Closes #29738 from bowenli86/doc. Authored-by: bowen.li <bowenli86@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0549c20) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
You are added to the Apache Spark contributor group and SPARK-32865 is assigned to you. |
|
Test build #128597 has finished for PR 29738 at commit
|
Member
Author
|
@dongjoon-hyun Thank you very much, Dongjoon! I look forward to working with you and the community in the future |
Member
|
:) We do, too. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…SPARK_VERSION correctly ### What changes were proposed in this pull request? In https://github.com/apache/spark/blame/master/docs/quick-start.md#L402,it should be `{{site.SPARK_VERSION}}` rather than `{site.SPARK_VERSION}` ### Why are the changes needed? SPARK_VERSION isn't displayed correctly, as shown below  ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tested locally, as shown below  Closes apache#29738 from bowenli86/doc. Authored-by: bowen.li <bowenli86@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 0549c20) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In https://github.com/apache/spark/blame/master/docs/quick-start.md#L402,it should be
{{site.SPARK_VERSION}}rather than{site.SPARK_VERSION}Why are the changes needed?
SPARK_VERSION isn't displayed correctly, as shown below
Does this PR introduce any user-facing change?
no
How was this patch tested?
tested locally, as shown below