[SPARK-32779][SQL][Follow-up] Delete Unused code #29736
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Catalog in withClient flow, this leads to DeadLock
|
Test build #128589 has finished for PR 29736 at commit
|
sandeep-katta
changed the title
Contributor
Author
|
retest this please |
|
Test build #128591 has finished for PR 29736 at commit
|
Member
|
cc @dongjoon-hyun fyi |
HyukjinKwon
approved these changes
Sep 12, 2020
dongjoon-hyun
approved these changes
Sep 12, 2020
Member
There was a problem hiding this comment.
+1, LGTM. Merged to master/3.0.
Thank you, @sandeep-katta and @HyukjinKwon .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 12, 2020
### What changes were proposed in this pull request? Follow-up PR as per the review comments in [29649](https://github.com/apache/spark/pull/29649/files/8d45542e915bea1b321f42988b407091065a2539#r487140171) ### Why are the changes needed? Delete the un used code ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes #29736 from sandeep-katta/deadlockfollowup. Authored-by: sandeep.katta <sandeep.katta2007@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2009f95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
### What changes were proposed in this pull request? Follow-up PR as per the review comments in [29649](https://github.com/apache/spark/pull/29649/files/8d45542e915bea1b321f42988b407091065a2539#r487140171) ### Why are the changes needed? Delete the un used code ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes apache#29736 from sandeep-katta/deadlockfollowup. Authored-by: sandeep.katta <sandeep.katta2007@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 2009f95) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow-up PR as per the review comments in 29649
Why are the changes needed?
Delete the un used code
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT