[SPARK-32848][SQL] Let CostBasedJoinReorder produce same result in Scala 2.12 and 2.13 #29717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The optimization result of
CostBasedJoinReordermaybe different with same input in Scala 2.12 and Scala 2.13 if there are more than one same cost candidate plans.In this pr give a way to make the optimization result deterministic as much as possible with same input in Scala 2.12 and Scala 2.13, the main change of this pr as follow:
Change to use
LinkedHashMapinstead ofMapto storefoundPlansinJoinReorderDP.searchmethod to ensure same iteration order with same insert order because iteration order ofMapbehave differently under Scala 2.12 and 2.13Fixed
StarJoinCostBasedReorderSuiteaffected by the above changeRegenerate golden files affected by the above change.
Why are the changes needed?
We need to support a Scala 2.13 build.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Scala 2.12: Pass the Jenkins or GitHub Action
Scala 2.13: All tests passed.
Do the following:
Before
After