[SPARK-32800][SQL] Remove ExpressionSet from the 2.13 branch #29648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaliafroozeh
changed the title
HyukjinKwon
approved these changes
Sep 4, 2020
HyukjinKwon
reviewed
Sep 4, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
I think you should move sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala -> sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala back as well.
cloud-fan
approved these changes
Sep 4, 2020
gengliangwang
approved these changes
Sep 4, 2020
|
Test build #128295 has finished for PR 29648 at commit
|
|
Test build #128300 has finished for PR 29648 at commit
|
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup on #29598 and removes the
ExpressionSetclass from the 2.13 branch.Why are the changes needed?
ExpressionSetdoes not extend ScalaSetanymore and this class is no longer needed in the 2.13 branch.Does this PR introduce any user-facing change?
No
How was this patch tested?
Passes existing tests