Skip to content

[SPARK-32648][SS] Remove unused DELETE_ACTION in FileStreamSinkLog #29505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michal-wieleba wants to merge 1 commit into from
Closed

[SPARK-32648][SS] Remove unused DELETE_ACTION in FileStreamSinkLog #29505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLog.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,5 @@ class FileStreamSinkLog(

object FileStreamSinkLog {
val VERSION = 1
// TODO: SPARK-32648 This action hasn't been used from the introduction, better to remove this.
val DELETE_ACTION = "delete"
val ADD_ACTION = "add"
}
21 changes: 0 additions & 21 deletions ...core/src/test/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLogSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,7 @@ class FileStreamSinkLogSuite extends SparkFunSuite with SharedSparkSession {
test("shouldRetain") {
withFileStreamSinkLog { sinkLog =>
val log = newFakeSinkFileStatus("/a/b/x", FileStreamSinkLog.ADD_ACTION)
val log2 = newFakeSinkFileStatus("/a/b/z", FileStreamSinkLog.DELETE_ACTION)

assert(sinkLog.shouldRetain(log))
assert(sinkLog.shouldRetain(log2))
}
}

Expand All @@ -58,14 +55,6 @@ class FileStreamSinkLogSuite extends SparkFunSuite with SharedSparkSession {
blockReplication = 1,
blockSize = 10000L,
action = FileStreamSinkLog.ADD_ACTION),
SinkFileStatus(
path = "/a/b/y",
size = 200L,
isDir = false,
modificationTime = 2000L,
blockReplication = 2,
blockSize = 20000L,
action = FileStreamSinkLog.DELETE_ACTION),
SinkFileStatus(
path = "/a/b/z",
size = 300L,
Expand All @@ -78,7 +67,6 @@ class FileStreamSinkLogSuite extends SparkFunSuite with SharedSparkSession {
// scalastyle:off
val expected = s"""v$VERSION
|{"path":"/a/b/x","size":100,"isDir":false,"modificationTime":1000,"blockReplication":1,"blockSize":10000,"action":"add"}
|{"path":"/a/b/y","size":200,"isDir":false,"modificationTime":2000,"blockReplication":2,"blockSize":20000,"action":"delete"}
|{"path":"/a/b/z","size":300,"isDir":false,"modificationTime":3000,"blockReplication":3,"blockSize":30000,"action":"add"}""".stripMargin
// scalastyle:on
val baos = new ByteArrayOutputStream()
Expand All @@ -95,7 +83,6 @@ class FileStreamSinkLogSuite extends SparkFunSuite with SharedSparkSession {
// scalastyle:off
val logs = s"""v$VERSION
|{"path":"/a/b/x","size":100,"isDir":false,"modificationTime":1000,"blockReplication":1,"blockSize":10000,"action":"add"}
|{"path":"/a/b/y","size":200,"isDir":false,"modificationTime":2000,"blockReplication":2,"blockSize":20000,"action":"delete"}
|{"path":"/a/b/z","size":300,"isDir":false,"modificationTime":3000,"blockReplication":3,"blockSize":30000,"action":"add"}""".stripMargin
// scalastyle:on

Expand All @@ -108,14 +95,6 @@ class FileStreamSinkLogSuite extends SparkFunSuite with SharedSparkSession {
blockReplication = 1,
blockSize = 10000L,
action = FileStreamSinkLog.ADD_ACTION),
SinkFileStatus(
path = "/a/b/y",
size = 200L,
isDir = false,
modificationTime = 2000L,
blockReplication = 2,
blockSize = 20000L,
action = FileStreamSinkLog.DELETE_ACTION),
SinkFileStatus(
path = "/a/b/z",
size = 300L,
Expand Down