[SPARK-32669][SQL][TEST] Expression unit tests should explore all cases that can lead to null result #29493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #127695 has finished for PR 29493 at commit
|
Member
|
Thank you for pinging me, @cloud-fan . The two failures look relevant. Could you check them, please? |
maropu
reviewed
Aug 20, 2020
|
|
||
| protected def checkEvaluation( | ||
| expression: => Expression, expected: Any, inputRow: InternalRow = EmptyRow): Unit = { | ||
| checkNullability(expression.dataType, expression.nullable, expected) |
Member
There was a problem hiding this comment.
Nice update! I think this can make our tests more robust.
HyukjinKwon
changed the title
Member
|
Nice, looks good. The test failures indeed look related. |
viirya
reviewed
Aug 21, 2020
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
The idea looks also good to me.
viirya
reviewed
Aug 21, 2020
|
|
||
| private def checkNullability(dt: DataType, nullable: Boolean, expected: Any): Unit = { | ||
| expected match { | ||
| case null => assert(nullable) |
cloud-fan
changed the title
Contributor
Author
|
Sorry guys, I just realized that we already did it 2 years ago: #22375 I've changed this PR to add document about it, and ask people to explore all the null cases when writing tests. |
|
Test build #127724 has finished for PR 29493 at commit
|
Contributor
Author
|
retest this please |
HyukjinKwon
changed the title
|
Test build #127731 has finished for PR 29493 at commit
|
maropu
approved these changes
Aug 21, 2020
viirya
approved these changes
Aug 21, 2020
Member
|
Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add document to
ExpressionEvalHelper, and ask people to explore all the cases that can lead to null results (including null in struct fields, array elements and map values).This PR also fixes
ComplexTypeSuite.GetArrayStructFieldsto explore all the null cases.Why are the changes needed?
It happened several times that we hit correctness bugs caused by wrong expression nullability. When writing unit tests, we usually don't test the nullability flag directly, and it's too late to add such tests for all expressions.
In #22375, we extended the expression test framework, which checks the nullability flag when the expected result/field/element is null.
This requires the test cases to explore all the cases that can lead to null results
Does this PR introduce any user-facing change?
no
How was this patch tested?
I reverted 5d296ed locally, and
ComplexTypeSuitecan catch the bug.