[SPARK-32576][SQL][TEST][FOLLOWUP] Add tests for all the character array types in PostgresIntegrationSuite #29397
Conversation
|
@dongjoon-hyun Sorry to bother you, but could you check it again? |
...er-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala
Outdated
Show resolved
Hide resolved
|
It's probably worth adding a |
|
Thanks for the comment, @kujon. A |
…ray types in PostgresIntegrationSuite ### What changes were proposed in this pull request? This is a follow-up PR of #29192 that adds integration tests for character arrays in `PostgresIntegrationSuite`. ### Why are the changes needed? For better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add tests. Closes #29397 from maropu/SPARK-32576-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit 7990ea1) Signed-off-by: Takeshi Yamamuro <[email protected]>
|
Thanks, all! Merged to master/branch-3.0. |
| test("SPARK-32576: character array type tests") { | ||
| val df = sqlContext.read.jdbc(jdbcUrl, "char_array_types", new Properties) | ||
| val row = df.collect() | ||
| assert(row.length == 1) |
There was a problem hiding this comment.
oh, I missed that. But, its trivial, so I'll fix it next time I update this file. Anyway, thanks for the check, @yaooqinn
There was a problem hiding this comment.
That's alright. We don't currently have a style rule for that. == is already being used here and there too though I prefer === as well because it can compare, for example, arrays properly with a good error message.
|
Test build #127275 has finished for PR 29397 at commit
|
|
Test build #127277 has finished for PR 29397 at commit
|
|
Thank you for adding the test coverage, @maropu ! :) |
6 participants
What changes were proposed in this pull request?
This is a follow-up PR of #29192 that adds integration tests for character arrays in
PostgresIntegrationSuite.Why are the changes needed?
For better test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add tests.