[SPARK-32564][SQL][TEST][FOLLOWUP] Re-enable TPCDSQuerySuite with empty tables #29391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class TPCDSQueryWithStatsSuite extends TPCDSQuerySuite { | ||
|
|
||
| override def beforeAll(): Unit = { |
|
Test build #127222 has finished for PR 29391 at commit
|
| SQLConf.PLAN_STATS_ENABLED.key -> "true", | ||
| SQLConf.JOIN_REORDER_ENABLED.key -> "true" | ||
| ) | ||
| val sqlConfgs: Seq[(String, String)] = Nil |
Member
There was a problem hiding this comment.
BTW, this is not identical with the original status. I'm wondering if we don't need SQLConf.CROSS_JOINS_ENABLED.key -> "true" ? Previously, we had it.
Member
Author
There was a problem hiding this comment.
Yea, since it is enabled by default in 3.0+, I dropped it in the previous PR.
dongjoon-hyun
approved these changes
Aug 8, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thanks, @maropu .
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 8, 2020
…ty tables ### What changes were proposed in this pull request? This is the follow-up PR of #29384 to address the cloud-fan comment: #29384 (comment) This PR re-enables `TPCDSQuerySuite` with empty tables for better test coverages. ### Why are the changes needed? For better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes #29391 from maropu/SPARK-32564-FOLLOWUP. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 1df855b) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.0. |
Member
Author
|
Thanks, @dongjoon-hyun ! |
|
Test build #127230 has finished for PR 29391 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the follow-up PR of #29384 to address the @cloud-fan comment: #29384 (comment)
This PR re-enables
TPCDSQuerySuitewith empty tables for better test coverages.Why are the changes needed?
For better test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.