Skip to content

[SPARK-32575][CORE][TESTS] Bump up timeouts in BlockManagerDecommissionIntegrationSuite to reduce flakyness #29388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agrawaldevesh wants to merge 1 commit into from
Closed

[SPARK-32575][CORE][TESTS] Bump up timeouts in BlockManagerDecommissionIntegrationSuite to reduce flakyness #29388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class BlockManagerDecommissionIntegrationSuite extends SparkFunSuite with LocalS
val TaskEnded = "TASK_ENDED"
val JobEnded = "JOB_ENDED"

test(s"verify that an already running task which is going to cache data succeeds " +
testRetry(s"verify that an already running task which is going to cache data succeeds " +
s"on a decommissioned executor after task start") {
runDecomTest(true, false, TaskStarted)
}
Expand Down Expand Up @@ -89,7 +89,7 @@ class BlockManagerDecommissionIntegrationSuite extends SparkFunSuite with LocalS

val sleepIntervalMs = whenToDecom match {
// Increase the window of time b/w task started and ended so that we can decom within that.
case TaskStarted => 2000
case TaskStarted => 10000
// Make one task take a really short time so that we can decommission right after it is
// done but before its peers are done.
case TaskEnded =>
Expand Down Expand Up @@ -176,11 +176,11 @@ class BlockManagerDecommissionIntegrationSuite extends SparkFunSuite with LocalS
} else {
10.milliseconds
}
eventually(timeout(6.seconds), interval(intervalMs)) {
eventually(timeout(20.seconds), interval(intervalMs)) {
assert(getCandidateExecutorToDecom.isDefined)
}
} else {
ThreadUtils.awaitResult(asyncCount, 15.seconds)
ThreadUtils.awaitResult(asyncCount, 1.minute)
}

// Decommission one of the executors.
Expand All @@ -194,7 +194,7 @@ class BlockManagerDecommissionIntegrationSuite extends SparkFunSuite with LocalS
val decomTime = new SystemClock().getTimeMillis()

// Wait for job to finish.
val asyncCountResult = ThreadUtils.awaitResult(asyncCount, 15.seconds)
val asyncCountResult = ThreadUtils.awaitResult(asyncCount, 1.minute)
assert(asyncCountResult === numParts)
// All tasks finished, so accum should have been increased numParts times.
assert(accum.value === numParts)
Expand Down Expand Up @@ -226,7 +226,7 @@ class BlockManagerDecommissionIntegrationSuite extends SparkFunSuite with LocalS
}

// Wait for our respective blocks to have migrated
eventually(timeout(30.seconds), interval(10.milliseconds)) {
eventually(timeout(1.minute), interval(10.milliseconds)) {
if (persist) {
// One of our blocks should have moved.
val rddUpdates = blocksUpdated.filter { update =>
Expand Down