Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jul 31, 2020

What changes were proposed in this pull request?

This PR proposes to write the main page of PySpark documentation. The base work is finished at #29188.

Why are the changes needed?

For better usability and readability in PySpark documentation.

Does this PR introduce any user-facing change?

Yes, it creates a new main page as below:

Screen Shot 2020-07-31 at 10 02 44 PM

How was this patch tested?

Manually built the PySpark documentation.

cd python
make clean html

@SparkQA
Copy link

SparkQA commented Jul 31, 2020

Test build #126889 has finished for PR 29320 at commit 86be1f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main package? main page? I mean the PR title.

@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-32507][DOCS][PYTHON] Add main package for PySpark documentation [WIP][SPARK-32507][DOCS][PYTHON] Add main page for PySpark documentation Aug 1, 2020
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice

Copy link
Contributor

@nchammas nchammas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's docs/img/pyspark-components.pptx for?

@HyukjinKwon
Copy link
Member Author

What's docs/img/pyspark-components.pptx for?

It is for the image I used in the main page in case some people want to edit. There are other pptx files in docs/img as well for that purpose.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I just found a few typos.

@SparkQA
Copy link

SparkQA commented Aug 3, 2020

Test build #126951 has finished for PR 29320 at commit 6d5f6ef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-32507][DOCS][PYTHON] Add main page for PySpark documentation [SPARK-32507][DOCS][PYTHON] Add main page for PySpark documentation Aug 4, 2020
@SparkQA
Copy link

SparkQA commented Aug 4, 2020

Test build #127046 has finished for PR 29320 at commit dae09ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Thank you @viirya for approaching this. I am merging this to master.

@BryanCutler
Copy link
Member

Looks great, I think it will be very helpful for PySpark to have it's own main page. Thanks @HyukjinKwon !

@HyukjinKwon HyukjinKwon deleted the SPARK-32507 branch December 7, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants