Skip to content

[SPARK-32490][BUILD] Upgrade netty-all to 4.1.51.Final #29299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LuciferYang wants to merge 1 commit into from
Closed

[SPARK-32490][BUILD] Upgrade netty-all to 4.1.51.Final #29299

LuciferYang wants to merge 1 commit into from

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jul 30, 2020

What changes were proposed in this pull request?

This PR aims to bring the bug fixes from the latest netty version.

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass the Jenkins with the existing tests.

@srowen
Copy link
Member

srowen commented Jul 30, 2020

Sounds fine, if it doesn't introduce behavior changes or anything.

@srowen
Copy link
Member

srowen commented Jul 30, 2020

Jenkins test this please

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 31, 2020

ok to test

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 31, 2020

@LuciferYang, can you sync and rebase? then the tests should pass in GitHub Actions.

@SparkQA
Copy link

SparkQA commented Jul 31, 2020

Test build #126841 has finished for PR 29299 at commit 06a2b0d.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jul 31, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2020

Test build #126878 has finished for PR 29299 at commit 06a2b0d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Aug 2, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Aug 2, 2020

Test build #126937 has finished for PR 29299 at commit 06a2b0d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Aug 2, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Aug 2, 2020

Test build #126938 has finished for PR 29299 at commit 06a2b0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @LuciferYang and all.
Merged to master. The Jenkins passed.

GitHub Action failure is irrelevant to this one. It failed with R installation again.

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Aug 3, 2020

thx @dongjoon-hyun @maropu @HyukjinKwon @srowen , I'm very sorry that I've been busy with other things these days and haven't paid attention to this ...

@LuciferYang LuciferYang deleted the upgrade-netty-version branch August 3, 2020 07:26
@odidev
Copy link

odidev commented Sep 16, 2020

Hi,

Netty is upgraded to 4.1.51.Final by this PR, but it is not released in latest spark artifact on maven repo.
Can someone please confirm.

@srowen
Copy link
Member

srowen commented Sep 16, 2020

This was merged to Spark 3.1.0, not 3.0.1. Spark 3.1 is not released.
You can see that in the merge commit: 0693d8b

holdenk pushed a commit to holdenk/spark that referenced this pull request Oct 27, 2020
@LuciferYang @dongjoon-hyun
[SPARK-32490][BUILD] Upgrade netty-all to 4.1.51.Final
182cda0 
This PR aims to bring the bug fixes from the latest netty version.

- 4.1.48.Final: [https://github.com/netty/netty/milestone/223?closed=1](https://github.com/netty/netty/milestone/223?closed=1)(14 patches or issues)
- 4.1.49.Final: [https://github.com/netty/netty/milestone/224?closed=1](https://github.com/netty/netty/milestone/224?closed=1)(48 patches or issues)
- 4.1.50.Final: [https://github.com/netty/netty/milestone/225?closed=1](https://github.com/netty/netty/milestone/225?closed=1)(38 patches or issues)
- 4.1.51.Final: [https://github.com/netty/netty/milestone/226?closed=1](https://github.com/netty/netty/milestone/226?closed=1)(53 patches or issues)

No

Pass the Jenkins with the existing tests.

Closes apache#29299 from LuciferYang/upgrade-netty-version.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 0693d8b)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maropu maropu maropu approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

BUILD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@LuciferYang @srowen @HyukjinKwon @SparkQA @kiszk @maropu @odidev @dongjoon-hyun