-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32489][CORE] Pass core module UTs in Scala 2.13
#29298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change of this file is a simple sorting.
|
cc @srowen and @HyukjinKwon |
|
Wow this is nice |
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
Outdated
Show resolved
Hide resolved
|
Thank you, @HyukjinKwon . BTW, GitHub Action seems to be out of order for some reasons in both master branch and PR builder. |
|
Will take a look. |
|
Thanks. Take your time. This takes some time for review because it needs to run |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if the order would matter to any user. It shouldn't. That said, if it does, the ordering isn't stable or guaranteed at the moment anyway. So seems OK to me.
|
Retest this please. |
|
Thanks, @srowen . |
|
Retest this please. |
|
Rebased to the master to bring @HyukjinKwon 's GitHub Action fixes. Thanks! |
|
All test passed except the |
What changes were proposed in this pull request?
So far, we fixed many stuffs in
coremodule. This PR fixes the remaining UT failures in Scala 2.13.OneApplicationResource.environmentInfowill return a deterministic result forsparkProperties,hadoopProperties,systemProperties, andclasspathEntries.SubmitRestProtocolSuitehas Scala 2.13 answer in addition to the existing Scala 2.12 answer, and uses the expected answer based on the Scala runtime version.Why are the changes needed?
To support Scala 2.13.
Does this PR introduce any user-facing change?
Yes,
environmentInfois changed, but this fixes the indeterministic behavior.How was this patch tested?
BEFORE
AFTER