[SPARK-32488][SQL] Use @parser::members and @lexer::members to avoid generating unused code #29296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #126800 has finished for PR 29296 at commit
|
Member
Author
|
cc: @cloud-fan @viirya |
cloud-fan
approved these changes
Jul 30, 2020
Contributor
|
thanks, merging to master! |
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to update
SqlBse.g4for avoiding generating unused code.Currently, ANTLR generates unused methods and variables;
isValidDecimalandisHintare only used in the generated lexer. This PR changed the code to use@parser::membersand@lexer::membersto avoid it.Why are the changes needed?
To reduce unnecessary code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.