[SPARK-32248][BUILD] Recover Java 11 build in Github Actions #29295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @HyukjinKwon |
HyukjinKwon
approved these changes
Jul 30, 2020
Member
There was a problem hiding this comment.
I was worried about this JDK 11 build removed so I am okay to revive this for the time being. Looks good.
For the long term plan, I was actually thinking about:
- Copy Jenkins periodical jobs at https://amplab.cs.berkeley.edu/jenkins/ to GitHub Actions periodical jobs.
- Add a way to test JDK 11, JDK 8, Hive 1.2, Hive 2.3, Hadoop 2 and Hadoop 3 via PR title or tag (seems feasible). We we will run one default job but have a way to configure the profiles.
I was thinking that JDK 11 build will eventually live in the periodical builds (unless we change the default JDK and profiles). Does this plan make sense?
Member
Author
|
Sure. That sounds like a plan. We can get a freedom if we get more resource limit in GitHub Action. Thanks, @HyukjinKwon . Merged to master. |
Member
|
Thank you @dongjoon-hyun. |
|
Test build #126795 has finished for PR 29295 at commit
|
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
### What changes were proposed in this pull request? This PR aims to recover Java 11 build in `GitHub Action`. ### Why are the changes needed? This test coverage is removed before. Now, it's time to recover it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the GitHub Action. Closes apache#29295 from dongjoon-hyun/SPARK-32248. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 18, 2020
### What changes were proposed in this pull request? This PR aims to recover Java 11 build in `GitHub Action`. ### Why are the changes needed? This test coverage is removed before. Now, it's time to recover it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the GitHub Action. Closes apache#29295 from dongjoon-hyun/SPARK-32248. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR aims to recover Java 11 build in `GitHub Action`. ### Why are the changes needed? This test coverage is removed before. Now, it's time to recover it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the GitHub Action. Closes apache#29295 from dongjoon-hyun/SPARK-32248. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR aims to recover Java 11 build in `GitHub Action`. ### Why are the changes needed? This test coverage is removed before. Now, it's time to recover it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the GitHub Action. Closes apache#29295 from dongjoon-hyun/SPARK-32248. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Aug 19, 2020
### What changes were proposed in this pull request? This PR aims to recover Java 11 build in `GitHub Action`. ### Why are the changes needed? This test coverage is removed before. Now, it's time to recover it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the GitHub Action. Closes apache#29295 from dongjoon-hyun/SPARK-32248. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to recover Java 11 build in
GitHub Action.Why are the changes needed?
This test coverage is removed before. Now, it's time to recover it.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the GitHub Action.